Skip to content

inconsistent configuration of begin_offset for group consumer and consumer #92

@semarco

Description

@semarco

there is a inconsistency in configuring group-consumers and consumers.

looks like the begin_offset is directly on the consumer level options, but should be within the config option, like we configure group consumers.
documentation mentions config if of type :brod.consumer_options(), which includes begin_offset.

 [
  group_consumer: [
    config: [
      begin_offset: :earliest,
      offset_reset_policy: :reset_to_earliest,
      max_bytes: 0
    ]
  ],
  consumer: [
    begin_offset: :earliest,
    config: [
      offset_reset_policy: :reset_to_earliest,
      max_bytes: 0
    ]
  ]
]

should be

[
  group_consumer: [
    config: [
      begin_offset: :earliest,
      offset_reset_policy: :reset_to_earliest,
      max_bytes: 0
    ]
  ],
  consumer: [
    config: [
      begin_offset: :earliest,
      offset_reset_policy: :reset_to_earliest,
      max_bytes: 0
    ]
  ]
]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions