Q: Non static tools

[loeffel-io]

How to resolve tools like mysql/tmux/nvim with lib deps in the archive for example? https://dev.mysql.com/downloads/shell/

Thank you 🙏 Great rules btw!

[loeffel-io]

friendly ping @mark-thm @markelliot

[markelliot]

I'm not sure I understand, sorry -- there are a few examples of tools packaged in archives in this repo that extract and run just fine. Are you experiencing a specific issue?

[loeffel-io]

sorry, some more context:

  "nvim": {
    "binaries": [
      {
        "kind": "archive",
        "url": "https://github.com/neovim/neovim/releases/download/v0.11.4/nvim-macos-arm64.tar.gz",
        "file": "nvim-macos-arm64/bin/nvim",
        "sha256": "2de9623a4aa8cedf85c51e33bf8e85e05f6f291b923cd666c04704ccf164e8b7",
        "os": "macos",
        "cpu": "arm64",
        "type": "tar.gz"
      }
    ]
  }

this comes with the binary in nvim-macos-arm64/bin/nvim, which works to start but nvim can't start without errors since it can't find the other files in the archive and fails for example with

nvim-treesitter not installed
lspconfig is required not installed

same for mysql and so on

.
├── bin
│   └── nvim
├── lib
│   └── nvim
│       └── parser
│           ├── c.so
│           ├── lua.so
│           ├── markdown.so
│           ├── markdown_inline.so
│           ├── query.so
│           ├── vim.so
│           └── vimdoc.so
└── ...

[loeffel-io]

the nvim multitool deps are missing

tree bazel-bin/external/rules_multitool++multitool+multitool/tools/nvim

nvim
├── nvim ⇒ /private/var/tmp/_bazel_loeffel/2fabd7d17af7d39e3a69e911db3e2cd3/external/rules_multitool++multitool+multitool.nvim.macos_arm64/tools/nvim/macos_arm64_executable
├── nvim.repo_mapping
├── nvim.runfiles
│   ├── _main
│   ├── _repo_mapping ⇒ /private/var/tmp/_bazel_loeffel/2fabd7d17af7d39e3a69e911db3e2cd3/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/external/rules_multitool++multitool+multitool/tools/nvim/nvim.repo_mapping
│   ├── MANIFEST ⇒ /private/var/tmp/_bazel_loeffel/2fabd7d17af7d39e3a69e911db3e2cd3/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/external/rules_multitool++multitool+multitool/tools/nvim/nvim.runfiles_manifest
│   └── rules_multitool++multitool+multitool
│       └── tools
│           └── nvim
│               └── nvim ⇒ /private/var/tmp/_bazel_loeffel/2fabd7d17af7d39e3a69e911db3e2cd3/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/external/rules_multitool++multitool+multitool/tools/nvim/nvim
└── nvim.runfiles_manifest

[loeffel-io]

this works also would be nice to manage this via multitool

http_archive = use_repo_rule("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "com_github_neovim_neovim",
    build_file_content = """exports_files(["bin/nvim"])""",
    sha256 = "2de9623a4aa8cedf85c51e33bf8e85e05f6f291b923cd666c04704ccf164e8b7",
    strip_prefix = "nvim-macos-arm64",
    urls = [
        "https://github.com/neovim/neovim/releases/download/v0.11.4/nvim-macos-arm64.tar.gz",
    ],
)

finds all deps:

bazel run @com_github_neovim_neovim//:bin/nvim -- --version 

multitool picks only the binary instead of all required runfiles in this case

[markelliot]

gotcha, want to take a stab at proposing a fix (and a test?) -- I think you basically need to update

rules_multitool/multitool/private/hub_repo_tool_template/tool.bzl.template

Lines 7 to 11 in 112f577

	def _tool_impl(ctx):
	toolchain = ctx.toolchains[_TOOLCHAIN_TYPE]
	output = ctx.actions.declare_file(ctx.label.name + toolchain.ext)
	ctx.actions.symlink(output = output, target_file = toolchain.executable)
	return [DefaultInfo(executable = output)]

to include the directory's runfiles