-
Notifications
You must be signed in to change notification settings - Fork 33
Open
Description
It appears that after fb992e1, stampVersion at https://github.com/bazel-contrib/publish-to-bcr/blob/6a577a5c83afe8461b36f08dd3ca3ab2ac1f12f2/src/domain/module-file.ts#L35 no longer works properly.
Here's a sample stdout from the Github Action:
https://github.com/bazel-contrib/rules_devicetree/actions/runs/16453092376/job/46503690621
Loading template files from /tmp/templates-3tj8oi
Creating entry for module version 0.1.1 in bazel-central-registry
Fetching release archive https://github.com/bazel-contrib/rules_devicetree/releases/download/v0.1.1/rules_devicetree-v0.1.1.tar.gz
The release archive's MODULE.bazel version ",
#
# Always leave version unset or set to does not match release version 0.1.1. Creating a version patch.
Successfully created entry for rules_devicetree@0.1.1
However, the generated file does NOT have the proper version stamped:
bazelbuild/bazel-central-registry@0e9a7f0
It is stamped at the comments:
# NOTE:
# version = "0.1.1",
So, either stampVersion needs to be fixed, or we need to have an explicit version = "" line without the leading #.
Metadata
Metadata
Assignees
Labels
No labels