Skip to content

Commit 96996aa

Browse files
committed
fix: Add comments to clarify handling of deleted configurations in failure and success info storage
1 parent 2c1b485 commit 96996aa

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

src/backends/github_issues.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def _store_failure_info(service_config_id, exception, response=None):
129129

130130
config.save()
131131
except MessagingServiceConfig.DoesNotExist:
132-
pass
132+
pass # Config was deleted, nothing to update
133133

134134

135135
def _store_success_info(service_config_id):
@@ -142,7 +142,7 @@ def _store_success_info(service_config_id):
142142
config.clear_failure_status()
143143
config.save()
144144
except MessagingServiceConfig.DoesNotExist:
145-
pass
145+
pass # Config was deleted, nothing to update
146146

147147

148148
@shared_task

src/backends/jira_cloud.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def _store_failure_info(service_config_id, exception, response=None):
146146

147147
config.save()
148148
except MessagingServiceConfig.DoesNotExist:
149-
pass
149+
pass # Config was deleted, nothing to update
150150

151151

152152
def _store_success_info(service_config_id):
@@ -159,7 +159,7 @@ def _store_success_info(service_config_id):
159159
config.clear_failure_status()
160160
config.save()
161161
except MessagingServiceConfig.DoesNotExist:
162-
pass
162+
pass # Config was deleted, nothing to update
163163

164164

165165
@shared_task

src/backends/microsoft_teams.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def _store_failure_info(service_config_id, exception, response=None):
113113

114114
config.save()
115115
except MessagingServiceConfig.DoesNotExist:
116-
pass
116+
pass # Config was deleted, nothing to update
117117

118118

119119
def _store_success_info(service_config_id):
@@ -126,7 +126,7 @@ def _store_success_info(service_config_id):
126126
config.clear_failure_status()
127127
config.save()
128128
except MessagingServiceConfig.DoesNotExist:
129-
pass
129+
pass # Config was deleted, nothing to update
130130

131131

132132
def _build_adaptive_card(title, facts, title_color, issue_url=None, mention_users=None):

src/backends/pagerduty.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def _store_failure_info(service_config_id, exception, response=None):
117117

118118
config.save()
119119
except MessagingServiceConfig.DoesNotExist:
120-
pass
120+
pass # Config was deleted, nothing to update
121121

122122

123123
def _store_success_info(service_config_id):
@@ -130,7 +130,7 @@ def _store_success_info(service_config_id):
130130
config.clear_failure_status()
131131
config.save()
132132
except MessagingServiceConfig.DoesNotExist:
133-
pass
133+
pass # Config was deleted, nothing to update
134134

135135

136136
@shared_task

src/backends/webhook.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ def _store_failure_info(service_config_id, exception, response=None):
134134

135135
config.save()
136136
except MessagingServiceConfig.DoesNotExist:
137-
pass
137+
pass # Config was deleted, nothing to update
138138

139139

140140
def _store_success_info(service_config_id):
@@ -147,7 +147,7 @@ def _store_success_info(service_config_id):
147147
config.clear_failure_status()
148148
config.save()
149149
except MessagingServiceConfig.DoesNotExist:
150-
pass
150+
pass # Config was deleted, nothing to update
151151

152152

153153
@shared_task

0 commit comments

Comments
 (0)