Review use of 'catch' and erlang:get_stacktrace() Riak-wide

[slfritchie]

Or, for an alternate title, "catch" without "try" considered harmful. See http://erlang.org/pipermail/erlang-questions/2013-November/075928.html and subsequent discussion for details.

[evanmcc]

If I am reading this correctly, the issue is that they are using exceptions
for flow control. Do we do that anywhere?

[slfritchie]

I know that past code that I myself have written uses 1-liner 'catch' statements. Any such that I or others have planted should probably be removed.

[evanmcc]

Done with the intention of usually hitting the exception, on hot paths?

[jrwest]

marked for 2.1 for now since this is "future un-categorized work". I'd actually love to see it done for 2.0.1, however, Happy to discuss.