Skip to content

fix: relative path when on gha #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meyer9 merged 1 commit into from
Oct 28, 2025
Merged

fix: relative path when on gha #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions report/src/services/dataService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ export class DataService {
private baseUrl: string;

constructor(baseUrl: string) {
this.baseUrl = baseUrl.replace(/\/$/, ""); // Remove trailing slash
this.baseUrl = baseUrl.replace(/\/$/, "") + "/"; // Ensure trailing slash
}

async getMetadata(): Promise<BenchmarkRuns> {
const response = await fetch(`${this.baseUrl}/output/metadata.json`);
const response = await fetch(`${this.baseUrl}output/metadata.json`);

if (!response.ok) {
throw new Error(
Expand All @@ -27,7 +27,7 @@ export class DataService {
}

async getMetrics(outputDir: string, nodeType: string): Promise<MetricData[]> {
const metricsPath = `${this.baseUrl}/output/${outputDir}/metrics-${nodeType}.json`;
const metricsPath = `${this.baseUrl}output/${outputDir}/metrics-${nodeType}.json`;
const response = await fetch(metricsPath);

if (!response.ok) {
Expand Down Expand Up @@ -72,7 +72,7 @@ export function getDataSourceConfig(): DataServiceConfig {
const dataSource = getEnvVar("DATA_SOURCE") || "static";

if (dataSource === "api" && apiBaseUrl) {
// API mode: use the configured API base URL
// API mode: use the configured API base URL (ensure trailing slash)
return { baseUrl: apiBaseUrl };
} else {
// Static mode: use current origin (empty string means relative to current domain)
Expand Down
Loading