From c663ed439f256a9aac5076a23b33fc97ab881378 Mon Sep 17 00:00:00 2001 From: Thomas Weisbach Date: Mon, 21 Nov 2011 19:11:51 +0900 Subject: [PATCH 1/3] Update for Xcode 4.2 compatibility. --- DropScript.xcodeproj/project.pbxproj | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/DropScript.xcodeproj/project.pbxproj b/DropScript.xcodeproj/project.pbxproj index 977328d..2142374 100644 --- a/DropScript.xcodeproj/project.pbxproj +++ b/DropScript.xcodeproj/project.pbxproj @@ -3,7 +3,7 @@ archiveVersion = 1; classes = { }; - objectVersion = 42; + objectVersion = 46; objects = { /* Begin PBXBuildFile section */ @@ -173,9 +173,16 @@ /* Begin PBXProject section */ 29B97313FDCFA39411CA2CEA /* Project object */ = { isa = PBXProject; + attributes = { + LastUpgradeCheck = 0420; + }; buildConfigurationList = 05FC290B115FE35700A9079C /* Build configuration list for PBXProject "DropScript" */; - compatibilityVersion = "Xcode 2.4"; + compatibilityVersion = "Xcode 3.2"; + developmentRegion = English; hasScannedForEncodings = 1; + knownRegions = ( + en, + ); mainGroup = 29B97314FDCFA39411CA2CEA /* DropScript */; projectDirPath = ""; projectRoot = ""; @@ -252,24 +259,23 @@ 05FC2905115FE35600A9079C /* Development */ = { isa = XCBuildConfiguration; buildSettings = { - ARCHS = "$(ARCHS_STANDARD_32_BIT_PRE_XCODE_3_1)"; - ARCHS_STANDARD_32_BIT_PRE_XCODE_3_1 = "ppc i386"; - SDKROOT = /Developer/SDKs/MacOSX10.5.sdk; + MACOSX_DEPLOYMENT_TARGET = 10.4; + SDKROOT = macosx; }; name = Development; }; 05FC2906115FE35600A9079C /* Deployment */ = { isa = XCBuildConfiguration; buildSettings = { - ARCHS = "$(ARCHS_STANDARD_32_BIT_PRE_XCODE_3_1)"; - ARCHS_STANDARD_32_BIT_PRE_XCODE_3_1 = "ppc i386"; - SDKROOT = /Developer/SDKs/MacOSX10.5.sdk; + MACOSX_DEPLOYMENT_TARGET = 10.4; + SDKROOT = macosx; }; name = Deployment; }; 05FC2907115FE35600A9079C /* Default */ = { isa = XCBuildConfiguration; buildSettings = { + MACOSX_DEPLOYMENT_TARGET = 10.4; }; name = Default; }; @@ -279,13 +285,11 @@ COPY_PHASE_STRIP = NO; DEBUGGING_SYMBOLS = YES; GCC_DYNAMIC_NO_PIC = NO; - GCC_ENABLE_FIX_AND_CONTINUE = YES; GCC_GENERATE_DEBUGGING_SYMBOLS = YES; GCC_OPTIMIZATION_LEVEL = 0; GCC_TREAT_WARNINGS_AS_ERRORS = YES; INFOPLIST_FILE = Info.plist; INSTALL_PATH = /Applications/DropScript; - MACOSX_DEPLOYMENT_TARGET = 10.1; PRODUCT_NAME = DropScript; UNSTRIPPED_PRODUCT = YES; WARNING_CFLAGS = "-Wall"; @@ -303,7 +307,6 @@ GCC_TREAT_WARNINGS_AS_ERRORS = YES; INFOPLIST_FILE = Info.plist; INSTALL_PATH = /Applications; - MACOSX_DEPLOYMENT_TARGET = 10.1; PRODUCT_NAME = DropScript; WARNING_CFLAGS = "-Wall"; WRAPPER_EXTENSION = app; From a260fa4bce44e91d6b263a7642362361011fcdf9 Mon Sep 17 00:00:00 2001 From: Thomas Weisbach Date: Mon, 21 Nov 2011 19:12:33 +0900 Subject: [PATCH 2/3] Stop warning, unnecessary parameter. --- ApplicationController.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ApplicationController.m b/ApplicationController.m index 8776791..7b0eef9 100644 --- a/ApplicationController.m +++ b/ApplicationController.m @@ -132,7 +132,7 @@ - (void) dropService: (NSPasteboard*) aPasteBoard else { *anError = @"Unknown data type in pasteboard."; - NSLog(@"Service invoked with no valid pasteboard data.", 0); + NSLog(@"Service invoked with no valid pasteboard data."); } } From 6dba55d549633de0bbeb4598149dfbb6de8f3924 Mon Sep 17 00:00:00 2001 From: Thomas Weisbach Date: Mon, 21 Nov 2011 19:24:52 +0900 Subject: [PATCH 3/3] Fix memory leak --- ApplicationController.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ApplicationController.m b/ApplicationController.m index 7b0eef9..f6f3bd3 100644 --- a/ApplicationController.m +++ b/ApplicationController.m @@ -141,7 +141,7 @@ - (void)handleURIEvent:(NSAppleEventDescriptor *)event { NSString *urlStr = [[event paramDescriptorForKeyword:keyDirectObject] stringValue]; - NSMutableArray *urls = [[NSMutableArray alloc] init]; + NSMutableArray *urls = [[[NSMutableArray alloc] init] autorelease]; [urls addObject: urlStr]; [self runScriptWithArguments: urls]; }