Wrong field name in login() method

[martinjuiz]

The method RocketChatClientCallBuilder.login in master branch is using username field to set the username value but the API is expecting user instead.
By using username the response is always 401 Unauthorized (other endpoints are already accepting username so my understanding is this field name should be standardised).

[col-panic]

Could you please provide a sample case / test-case showing a scenario where the current login fails and subsequently works (using your modification)? I do currently use the tool as is for login, but it works with RocketChat 2.3!

[markusstoll]

It does not work with RocketChat 3.3
I could verify by changing paramer username to user to make it work

[col-panic]

I just tested against 3.3 and it seems to work. What is your usage scenario? RocketChatClientCallBuilder.login is a private method you should not be required to directly use it?

[markusstoll]

I tried with rocket-chat-rest-client obtained via Maven and failed against Rocket.Chat V3.3.0 (using new RocketChatClient(<params>))

To make it work, I checked out the project and made the named change and again used new RocketChatClient(<params>).

I guess you agree, that the Rocket.Chat API https://docs.rocket.chat/api/rest-api/methods/authentication/login does require the parameter user rather than username?

[col-panic]

so you tried the maven version, not the current master in this repository? The version distributed via maven is quite old.

It does not matter whether we agree on the documentation - first a test must fail - to this end I updated the build to test against 3.3.3 which does build correctly.

Please test your code using the current master as served in this repo, you could also share a snipped of what is not working for you, to include as additional test.

[markusstoll]

Well, I did not write clear enough. After failing with maven version, I cloned current master and debugged and verified the failure. Then I changed the parameter name to user and got things working.

my test code is a 2 liner:

rc = new RocketChatClient(<params>)
rc.getGroupsApi()

[col-panic]

I just tested this current code against my running productive 3.3.3 installation with

RocketChatClient rc = new RocketChatClient("https://rocketchat.mydomain.com", "user", "password");
Group[] list = rc.getGroupsApi().list();
for (Group group : list) {
	System.out.println(group);
}

and it works without a problem.

[markusstoll]

So the point might very well be on the other end. My Rocket.Chat installation is a new installation of Version 33.0 from Scratch using the official docker image.
I am going to update it to 3.3.3 for verification

[markusstoll]

After update to Rocket.Chat V3.3.3 I still observer the same.

I reduced the client part to a setup in PostMan, still the same. Using username does not work, using user does.

[Falco20019]

Both username and user work. I had the same problem, but it was due to using LDAP. Try using the email address or the display name. These work. Sadly not the LDAP username... That's a problem of Rocket.Chat and not of this library.