Skip to content

Make cli command options consistent: check only or fix (dry-run mode) #621

@sypets

Description

@sypets
command how it deals with checking vs. fixing
container:deleteChildrenWithNonExistingParent fixes in any case, no dry-run mode
container:deleteChildrenWithWrongPid fixes in any case, no dry-run mode
container:fixContainerParentForConnectedMode fixes in any case, no dry-run mode
container:fixLanguageMode fixes in any case, no dry-run mode
container:integrity only checks and reports problems, no fixing
container:sorting only fixes if option --apply is passed, default is dry-run
container:sorting-in-page only fixes if option --apply is passed

Suggestion

  • Be consistent on behaviour of command without option (currently, sometimes it fixes without option, sometimes with option).
  • Always make it possible to differentiate between automatical fix or check (dry-run). Sometimes it is useful to only report problems and check them first or fix manually.

Personally, I find using an option such as --dry-run (-d) more obvious and consistent with other commands.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions