Skip to content

CollapseViewHelper blocks collapsing of nested containers #17

@EvilBMP

Description

@EvilBMP

Right now, the CollapseViewHelper has the following condition:

if ($type instanceof GridColumnItem && !$type instanceof ContainerGridColumnItem) {

Why is the type ContainerGridColumnItem forbidden here? This blocks the ability to collapse container elements inside another container element.

Is this by design or a bug?

IMHO this condition should be if ($type instanceof GridColumnItem || $type instanceof ContainerGridColumnItem) {

I can provide a PR but wanted to discuss this first. Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions