GitBridgeApiController.mjs

[yu-i-i]

Hi.

Is this your code, or you modified the already existing code by someone else?

https://github.com/ayaka-notes/overleaf-pro/blob/server-pro/services/web/modules/git-bridge/app/src/GitBridgeApiController.mjs

I'm asking because I want to make a proper author reference, and the coding style in this file does not look like yours.

Update: The same question is about

https://github.com/ayaka-notes/overleaf-pro/blob/server-pro/services/web/modules/oauth2-server/app/src/OAuth2Model.mjs

The majority of this code is not needed and not used by your git-bridge implementation. If it was written by you, why did you do this? If not, where did you take it from?

[Musicminion]

Yes, all of those are my code.

oauth2-server is responsible for git-bridge personal access token management.

[yu-i-i]

oauth2-server is responsible for git-bridge personal access token management.

From OAuth2Model.mjs, only two functions are used, and it would be easy to live without them. The point is that the native Overleaf git-bridge, written in Java, knows nothing about oauth2 and does not use it. You should know this if you implemented the missing part. So what is the point of implementing the complete model? It is not used.

I understand that if you already have an oauth2-server implementation, it is convenient to take a couple of functions from existing code and use them in the middleware. But why reimplement almost the same functionality in AuthPersonalAccessTokenManager.mjs? I do not understand that. That is why it looked to me as if the oauth2-server code may have been reused from another source, possibly Overleaf Pro, rather than designed specifically for this implementation. I am not going to report my doubts to Overleaf, I am just explaining why I have them.

My code is used by several groups in European universities, and I do not want to create problems for them or for myself by using code without the proper license. That is why I already removed the oauth server code path, especially OAuth2Model.mjs, and implemented everything based on your OAuthPersonalAccessTokenManager.mjs (which is, without any doubt, your code).

In any case, this is no longer relevant for me. I rewrote the authentication and authorization logic, and I have almost finished reimplementing the functionality of GitBridgeApiController.mjs. So my questions are no longer relevant.

The rest, especially the frontend, I took from your code, fixed some bugs, improved it a bit, and will publish it soon.

[Musicminion]

oauth2-server is responsible for git-bridge personal access token management.

From OAuth2Model.mjs, only two functions are used, and it would be easy to live without them. The point is that the native Overleaf git-bridge, written in Java, knows nothing about oauth2 and does not use it. You should know this if you implemented the missing part. So what is the point of implementing the complete model? It is not used.

I understand that if you already have an oauth2-server implementation, it is convenient to take a couple of functions from existing code and use them in the middleware. But why reimplement almost the same functionality in AuthPersonalAccessTokenManager.mjs? I do not understand that. That is why it looked to me as if the oauth2-server code may have been reused from another source, possibly Overleaf Pro, rather than designed specifically for this implementation. I am not going to report my doubts to Overleaf, I am just explaining why I have them.

My code is used by several groups in European universities, and I do not want to create problems for them or for myself by using code without the proper license. That is why I already removed the oauth server code path, especially OAuth2Model.mjs, and implemented everything based on your OAuthPersonalAccessTokenManager.mjs (which is, without any doubt, your code).

In any case, this is no longer relevant for me. I rewrote the authentication and authorization logic, and I have almost finished reimplementing the functionality of GitBridgeApiController.mjs. So my questions are no longer relevant.

The rest, especially the frontend, I took from your code, fixed some bugs, improved it a bit, and will publish it soon.

Thank you very much for your detailed reply. Let me explain the situation. I started implementing Git Bridge about two years ago. At that time, I noticed that some code referenced the oauth2-server component, so I implemented that module myself. The implementation was fairly rough, as I was thinking it might later be connected to an SSO system. Back then I only completed the logic for git pull, and it was even using virtual or mock data. I was not very familiar with how git push should apply the changes back into Overleaf. So it end up with failure.

However, I recently returned to development on this project. For the sake of simplicity, I directly copied over the source code that I had written 2 years ago. That is why it may appear to you as though it was referenced from or connected to an existing system.