Add axon-pr-reviewer TaskSpawner to replace cubic-dev-ai by axon-agent[bot] · Pull Request #409 · kelos-dev/kelos

axon-agent · 2026-02-22T05:22:02Z

Summary

Adds a new axon-pr-reviewer TaskSpawner that watches for open PRs labeled ok-to-test and performs automated code reviews
Replaces the external cubic-dev-ai GitHub App with axon's own self-development capabilities
Updates the self-development README to document the new TaskSpawner

Details

The cubic-dev-ai app provides automated code reviews, PR description summaries, and codebase memory. This PR replaces that functionality with a native axon TaskSpawner that:

Triggers on PRs: Uses githubIssues.types: ["pulls"] with labels: ["ok-to-test"] to watch for PRs ready for review
Reviews the diff: Reads the full PR diff and evaluates correctness, test coverage, style/conventions, security, and simplicity
Posts structured feedback: Posts a review comment with summary, detailed findings, and a verdict (LGTM or changes requested)
Re-reviews on new commits: Uses SHA comparison to detect new commits. The task TTL is set to zero so it is deleted immediately after review, letting the spawner rediscover the PR on the next poll cycle. If the head SHA matches the last reviewed SHA, the review is skipped
Incremental follow-up reviews: On follow-up reviews, focuses on the incremental diff (changes since the last reviewed commit) while using the full PR diff for overall context

The reviewer is read-only — it does not push code or modify files.

Closes #408

Test plan

Verify the TaskSpawner YAML is valid against the Axon CRD schema
Deploy and confirm it picks up PRs labeled ok-to-test
Verify review comments are posted correctly
Confirm re-review triggers on new commits and skips when HEAD is unchanged

🤖 Generated with Claude Code

cubic-dev-ai

No issues found across 2 files

gjkim42

I'd like to review the latest diff every time the pr is updated.

gjkim42 · 2026-02-22T05:42:40Z

/reset-worker

cubic-dev-ai

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="self-development/axon-pr-reviewer.yaml">

<violation number="1" location="self-development/axon-pr-reviewer.yaml:52">
P2: Guard the `capture` call so comments without a "Reviewed commit" line don’t make the jq command fail and force re-reviews.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

self-development/axon-pr-reviewer.yaml

gjkim42

/reset-worker

gjkim42 · 2026-02-23T13:43:56Z

self-development/axon-pr-reviewer.yaml

+      name: axon-agent
+    model: opus
+    type: claude-code
+    ttlSecondsAfterFinished: 0


so... this will constantly spawn tasks for the same PR even if it doesn't actually code review it.
it will consume tokens continuously.

What would be the better solution?

Introduce a new TaskSpawner that watches for pull requests labeled ok-to-test and performs automated code reviews, replacing the external cubic-dev-ai GitHub App. The reviewer reads the full PR diff, checks it against project conventions, evaluates correctness, test coverage, style, security, and simplicity, then posts a structured review comment on the PR. Closes #408 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Remove excludeLabels and axon/needs-input labeling so the PR reviewer re-triggers after Task TTL expires. Add a new-commits check so the agent skips posting if nothing changed since the last review. Closes #408 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Set ttlSecondsAfterFinished to 0 so the review task is deleted immediately after finishing. This lets the spawner rediscover the PR on the next poll cycle and re-review within ~1 minute of new commits being pushed, instead of waiting up to 1 hour for the old TTL to expire. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Replace date-based comparison with SHA comparison when deciding whether to skip a review. The reviewer now compares the PR head SHA against the commit_id from the last axon review, which is more reliable across rebases and force pushes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Replace broken {owner}/{repo} placeholders with dynamic repo detection via `gh repo view` and `gh pr view` - Add null check for LAST_REVIEWED_SHA so the first review always runs - Match review comments by "Axon PR Reviewer" instead of "Axon Agent" to align with the actual review comment format - Include reviewed commit SHA in review output for reliable comparison - Add diagnostic logging for review decisions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Switch review posting from `gh pr review --comment` to `gh pr comment` so that the skip-review check can reliably find prior reviews via `gh pr view --json comments`. The previous approach used the reviews API which required fragile jq filters on user login and body content. The new approach parses the reviewed commit SHA directly from comment bodies, making skip detection consistent with the posting mechanism. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add the jq try operator (?) to the capture() call so that comments matching "Axon PR Reviewer" but lacking a "Reviewed commit" line silently produce no output instead of erroring and forcing unnecessary re-reviews. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

When the PR has been reviewed before, the reviewer now fetches the incremental diff (LAST_REVIEWED...HEAD_SHA) in addition to the full PR diff. Follow-up review comments use a distinct format that shows the "Changes since" SHA and focuses feedback on the new commits while noting whether prior feedback has been addressed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Address review feedback: ttlSecondsAfterFinished: 0 caused the spawner to continuously create new review tasks every poll cycle (1 minute), wasting tokens even when the PR had not changed. Switch to TTL 3600s (matching axon-workers) so the Task persists after completion and prevents re-spawning. Re-reviews can be triggered via /reset-worker. Remove the skip-if-already-reviewed logic from the prompt since the spawner's own deduplication (by task name) now handles this. The agent still detects previous reviews for incremental diff purposes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

axon-agent bot added generated-by-kelos ok-to-test labels Feb 22, 2026

github-actions bot added needs-triage needs-kind Indicates an issue or PR lacks a kind/* label needs-actor needs-priority labels Feb 22, 2026

cubic-dev-ai bot reviewed Feb 22, 2026

View reviewed changes

gjkim42 requested changes Feb 22, 2026

View reviewed changes

axon-agent bot force-pushed the axon-task-408 branch 2 times, most recently from 774db87 to b52cfaf Compare February 22, 2026 09:04

cubic-dev-ai bot reviewed Feb 22, 2026

View reviewed changes

self-development/axon-pr-reviewer.yaml Outdated Show resolved Hide resolved

axon-agent bot mentioned this pull request Feb 23, 2026

Replace cubic-dev-ai app #408

Open

gjkim42 mentioned this pull request Feb 23, 2026

Add PR reviewer TaskSpawner for automated code review #413

Closed

5 tasks

gjkim42 requested changes Feb 23, 2026

View reviewed changes

gjkim42 and others added 9 commits February 23, 2026 13:45

axon-agent bot force-pushed the axon-task-408 branch from 405e1c3 to 85ceeff Compare February 23, 2026 13:48

gjkim42 closed this Feb 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add axon-pr-reviewer TaskSpawner to replace cubic-dev-ai#409

Add axon-pr-reviewer TaskSpawner to replace cubic-dev-ai#409
axon-agent[bot] wants to merge 9 commits intomainfrom
axon-task-408

axon-agent bot commented Feb 22, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

gjkim42 left a comment

Uh oh!

gjkim42 commented Feb 22, 2026

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

gjkim42 left a comment

Uh oh!

gjkim42 Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

axon-agent bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Test plan

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

gjkim42 left a comment

Choose a reason for hiding this comment

Uh oh!

gjkim42 commented Feb 22, 2026

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gjkim42 left a comment

Choose a reason for hiding this comment

Uh oh!

gjkim42 Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

axon-agent bot commented Feb 22, 2026 •

edited

Loading