Skip to content

Docs: Update p4-code-review docs to include guidance on production limitations #799

@cw255

Description

@cw255

What were you searching in the docs?

The current module does not consider the requirement of p4-code-review to need persistent storage in production environments to avoid data loss at reboot. Examples include additional config.php key / values that aren't exposed as EVs and worker queues if not fully processed before shutdown. Additionally worker queues do not support NFS / EFS (https://portal.perforce.com/s/article/Swarm-workers-not-processing-tasks-queue-filesystem-on-NFS) so this should probably be highlighted as part of the same recommendations as this would be most peoples go-to option when trying to solve this issue

Is this related to an existing documentation section?

https://github.com/aws-games/cloud-game-development-toolkit/blob/main/modules/perforce/README.md and https://github.com/aws-games/cloud-game-development-toolkit/tree/main/modules/perforce/modules/p4-code-review

How can we improve?

Highlight the limitations of the current deployment

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationtriageto be triaged by project maintainers

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions