Strict unmarshalling for generator.yaml

This validates whether `generator.yaml` are using real defined fields from
`pkg/config/*.go`. Strict unmarshalling rejects unknown fields.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: michaelhtm

go.mod

@@ -114,7 +114,7 @@ require (
 	k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738 // indirect
 	sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3 // indirect
 	sigs.k8s.io/structured-merge-diff/v4 v4.4.2 // indirect
-	sigs.k8s.io/yaml v1.4.0 // indirect
+	sigs.k8s.io/yaml v1.4.0
 )
 
 require (

pkg/config/config.go

@@ -16,7 +16,7 @@ package config
 import (
 	"io/ioutil"
 
-	"github.com/ghodss/yaml"
+	"sigs.k8s.io/yaml"
 )
 
 // Config represents instructions to the ACK code generator for a particular
@@ -194,7 +194,7 @@ func New(
 		return Config{}, err
 	}
 	gc := defaultConfig
-	if err = yaml.Unmarshal(content, &gc); err != nil {
+	if err = yaml.UnmarshalStrict(content, &gc); err != nil {
 		return Config{}, err
 	}
 	return gc, nil

pkg/config/documentation.go

@@ -3,7 +3,7 @@ package config
 import (
 	"io/ioutil"
 
-	"github.com/ghodss/yaml"
+	"sigs.k8s.io/yaml"
 )
 
 // DocumentationConfig represents the configuration of the documentation file,
@@ -44,7 +44,7 @@ func NewDocumentationConfig(
 		return DocumentationConfig{}, err
 	}
 	gc := DocumentationConfig{}
-	if err = yaml.Unmarshal(content, &gc); err != nil {
+	if err = yaml.UnmarshalStrict(content, &gc); err != nil {
 		return DocumentationConfig{}, err
 	}
 	return gc, nil

pkg/testdata/models/apis/emrcontainers/0000-00-00/generator-with-cycle.yaml

@@ -9,7 +9,8 @@ ignore:
   # - JobRun
   - ManagedEndpoint
   shape_names: null
-model_name: emr-containers
+sdk_names:
+  model_name: emr-containers
 operations:
   StartJobRun:
     operation_type: Create

pkg/testdata/models/apis/firehose/0000-00-00/generator-set-for-nested-field.yaml

@@ -1,4 +1,5 @@
-model_name: firehose
+sdk_names:
+  model_name: firehose
 ignore:
   resource_names:
      # - DeliveryStream

pkg/testdata/models/apis/mq/0000-00-00/generator-only-set-unchanged-fields.yaml

@@ -1,5 +1,5 @@
 ignore:
-  resources:
+  resource_names:
     - Configuration
     - User
   field_paths:

pkg/testdata/models/apis/mq/0000-00-00/generator.yaml

@@ -1,5 +1,5 @@
 ignore:
-  resources:
+  resource_names:
     - Configuration
     - User
   field_paths:

pkg/testdata/models/apis/rds/0000-00-00/generator.yaml

@@ -184,15 +184,11 @@ resources:
         from:
           operation: ModifyDBClusterParameterGroup
           path: Parameters
-        documentation: DEPRECATED - do not use.  Prefer ParameterOverrides instead.
       ParameterOverrides:
         custom_field:
           # Map keys are the parameter name and the values are the parameter value.
           # We automatically determine the "apply method" for parameters.
           map_of: String
-        documentation: These are ONLY user-defined parameter overrides for the
-          DB cluster parameter group. This does not contain default or system
-          parameters.
       Tags:
         compare:
           # We have a custom comparison function...

pkg/testdata/models/apis/route53/0000-00-00/generator.yaml

@@ -49,8 +49,6 @@ resources:
         is_immutable: true
       ID:
         is_primary_key: true
-        documentation: "ID represents the ChangeID that is returned after a successful 
-        ChangeResourceRecordSet request"
       MultiValueAnswer:
         from:
           operation: ListResourceRecordSets