Not working over HTTPS

[leopoldjoy]

@gmaclennan

Hello,

I was using github-webhook-middleware successfully over HTTP, however since I've setup my SSL, the package has stopped working. Here's my code:

const githubMiddleware = require('github-webhook-middleware')({
  secret: config.githubWebhookSecret
});

app.post('/webhook', githubMiddleware, (req, res) => {
  console.log('worked...');
});

I am not getting any output. I have even tried disabling SSL certificate validation on GitHub. Is this package expected to work with SSL?

[gmaclennan]

I have this working over https (using github-webhook-middleware) on Heroku with no problems: https://github.com/digidem/github-image-resizer

There could be many issues not related to this module that could cause this to fail. At least, it might help to know that this does module does work over ssl. I would try completely removing the middleware from that route and see if you see anything - then you can narrow down where the problem is.