Large code base: inconsistencies with `vue-tsc`

[BracketJohn]

Hi @auvred 🧇

Thanks for building this - it looks quite exciting. Our team is working on a huge Nuxt codebase (multiple 10k lines of code) and is suffering from slow TS-check-times, so this could definitely be an awesome improvement.

One problem we encounter when trying out the module is that it outputs a bunch of namespace declaration errors and none of the TS-errors in our codebase.

In my test we setup your module as follows:

pnpm add -D golar @golar/vue

I then introduced a basic TS-error to verify that everything works as expected:

let a = 5
if (a === 'test') { // expected error 1: no overlap
  a = new Date() // expected error 2: re-assignment to a different type
}

TS 5.9 then outputs:

❯ pnpm typecheck

> NODE_OPTIONS="--max_old_space_size=8192" nuxt typecheck

ℹ nuxt-auth setup starting                                                                                                                                         sidebase-auth 10:50:35 AM
[sidebase-auth 10:50:35 AM] ℹ Selected provider: authjs. Auth API location is /api/auth, if you would like to change this, see https://auth.sidebase.io/guide/application-side/configuration#baseurl. Ensure that the NuxtAuthHandler({ ... }) is there, see https://auth.sidebase.io/guide/authjs/nuxt-auth-handler
✔ nuxt-auth setup done                                                                                                                                             sidebase-auth 10:50:35 AM
ℹ Using default Tailwind CSS file                                                                                                                               nuxt:tailwindcss 10:50:35 AM
ℹ Nuxt Icon server bundle mode is set to local                                                                                                                                   10:50:35 AM
✔ Nuxt Icon discovered local-installed 4 collections: carbon, cif, line-md, material-symbols                                                                                     10:50:36 AM
✔ Nuxt Icon loaded local collection machinery-category with 7 icons                                                                                                              10:50:36 AM
✔ Nuxt Icon loaded local collection machinery-rubric with 15 icons                                                                                                               10:50:36 AM
✔ Nuxt Icon loaded local collection accessory with 29 icons                                                                                                                      10:50:36 AM
server/utils/registerPostResponseTask.ts:4:5 - error TS2367: This comparison appears to be unintentional because the types 'number' and 'string' have no overlap.

4 if (a === 'test') {
      ~~~~~~~~~~~~

server/utils/registerPostResponseTask.ts:5:3 - error TS2322: Type 'Date' is not assignable to type 'number'.

5   a = new Date()
    ~


Found 2 errors in the same file, starting at: server/utils/registerPostResponseTask.ts:4

While golar just outputs:

❯ pnpm golar --noEmit
node_modules/.pnpm/apexcharts@4.7.0/node_modules/apexcharts/types/apexcharts.d.ts:60:16 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

60 declare module ApexCharts {
                  ~~~~~~~~~~

node_modules/.pnpm/email-addresses@5.0.0/node_modules/email-addresses/lib/email-addresses.d.ts:1:16 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

1 declare module emailAddresses {
                 ~~~~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:3:15 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

3 export module Protocol {
                ~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:4:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

4   export module Accessibility {
                  ~~~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:343:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

343   export module Animation {
                    ~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:669:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

669   export module Audits {
                    ~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:1184:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

1184   export module Extensions {
                     ~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:1303:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

1303   export module Autofill {
                     ~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:1464:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

1464   export module BackgroundService {
                     ~~~~~~~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:1566:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

1566   export module Browser {
                     ~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:2019:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

2019   export module CSS {
                     ~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:3564:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

3564   export module CacheStorage {
                     ~~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:3761:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

3761   export module Cast {
                     ~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:3850:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

3850   export module DOM {
                     ~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:5255:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

5255   export module DOMDebugger {
                     ~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:5459:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

5459   export module EventBreakpoints {
                     ~~~~~~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:5496:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

5496   export module DOMSnapshot {
                     ~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:6034:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

6034   export module DOMStorage {
                     ~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:6117:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

6117   export module DeviceOrientation {
                     ~~~~~~~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:6151:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

6151   export module Emulation {
                     ~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:6827:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

6827   export module HeadlessExperimental {
                     ~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:6907:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

6907   export module IO {
                     ~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:6975:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

6975   export module FileSystem {
                     ~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:7023:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

7023   export module IndexedDB {
                     ~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:7402:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

7402   export module Input {
                     ~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:7925:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

7925   export module Inspector {
                     ~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:7961:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

7961   export module LayerTree {
                     ~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:8258:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

8258   export module Log {
                     ~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:8371:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

8371   export module Memory {
                     ~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:8551:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

8551   export module Network {
                     ~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:11031:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

11031   export module Overlay {
                      ~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:11854:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

11854   export module Page {
                      ~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:13925:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

13925   export module Performance {
                      ~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:14002:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

14002   export module PerformanceTimeline {
                      ~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:14094:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

14094   export module Security {
                      ~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:14399:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

14399   export module ServiceWorker {
                      ~~~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:14526:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

14526   export module Storage {
                      ~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:15482:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

15482   export module SystemInfo {
                      ~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:15706:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

15706   export module Target {
                      ~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:16171:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

16171   export module Tethering {
                      ~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:16211:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

16211   export module Tracing {
                      ~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:16428:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

16428   export module Fetch {
                      ~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:16803:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

16803   export module WebAudio {
                      ~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:17040:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

17040   export module WebAuthn {
                      ~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:17337:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

17337   export module Media {
                      ~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:17464:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

17464   export module DeviceAccess {
                      ~~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:17526:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

17526   export module Preload {
                      ~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:17716:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

17716   export module FedCm {
                      ~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:17824:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

17824   export module PWA {
                      ~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:17980:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

17980   export module BluetoothEmulation {
                      ~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:18177:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

18177   export module Console {
                      ~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:18246:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

18246   export module Debugger {
                      ~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:19273:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

19273   export module HeapProfiler {
                      ~~~~~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:19498:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

19498   export module Profiler {
                      ~~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:19768:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

19768   export module Runtime {
                      ~~~~~~~

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:20827:17 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

20827   export module Schema {
                      ~~~~~~


Found 56 errors in 3 files.

Errors  Files
     1  node_modules/.pnpm/apexcharts@4.7.0/node_modules/apexcharts/types/apexcharts.d.ts:60
     1  node_modules/.pnpm/email-addresses@5.0.0/node_modules/email-addresses/lib/email-addresses.d.ts:1
    54  node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:3

---

Is this a configuration error from our side?

Thanks again & have a good one!

[auvred]

Hi! Thanks so much for trying out Golar!

node_modules/.pnpm/playwright-core@1.52.0/node_modules/playwright-core/types/protocol.d.ts:3:15 - error TS1540: A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

3 export module Protocol {
                ~~~~~~~~

TS 7.0 reports modules-as-namespaces as errors (see microsoft/typescript-go#2873 (comment), microsoft/TypeScript#54500, and microsoft/TypeScript#62876)

The fix is relatively simple:

-export module Protocol {
+export namespace Protocol {

I hope this solves your issue! Let me know if anything else goes wrong!

UPD: oops, I didn't notice that the error comes from node_modules... playwright 1.58.0 contains the fix: microsoft/playwright#38558

UPD2: apexcharts fixed it in 5.6.0 - apexcharts/apexcharts.js@e893f8c

email-addresses has an open PR with a fix - jackbearheart/email-addresses#81

In the meantime, since you're using pnpm, you can patch the type declarations for these dependencies with pnpm patch. It should work just fine.

[BracketJohn]

Thanks for the quick reply & checking out the different deps!

What I'm uncertain about: Shouldn't golar still already catch the TS-error that is contained in our app? Specifically the

let a = 5
if (a === 'test') { // expected error 1: no overlap
  a = new Date() // expected error 2: re-assignment to a different type
}

which I added to test it?

As you can see above golar flags all of the node_module-namespace problems but doesn't flag the one I purposefully introduced!

[auvred]

As you can see above golar flags all of the node_module-namespace problems but doesn't flag the one I purposefully introduced!

Ahh, this is because typescript-go treats the module-as-namespace issue as a parsing/syntax error:

https://github.com/microsoft/typescript-go/blob/fcf298a0a146f26938a7e6ccd81340046a49d8a7/internal/parser/parser.go#L2147

Similar to other syntax errors, TypeScript doesn't perform type-checking unless the code is free of syntax errors.

[BracketJohn]

Thanks, that must be it! I'll attempt to just pnpm patch all deps for now to see if it works then, before attempting to upgrade all modules (as that in and of itself has overhead, e.g., apexcharts@5 is not longer MIT licensed, so upgrading that module at all could be impossible for us at the moment: https://apexcharts.com/new-licencing-model/)

[auvred]

as that in and of itself has overhead, e.g., apexcharts@5 is not longer MIT licensed

Oh, this must be tough... Anyway, good luck with this!

Since this issue isn't related to Golar, I'll close it. If you run into any other problems/questions, I'm more than happy to help, so don't hesitate to open a new issue!

Also, I'm curious how much faster Golar will run on your codebase compared to vue-tsc, so I'd appreciate it if you could share the results afterward. Thanks!

And since Golar is currently still very experimental, expect breaking changes to happen. I'll try to document migration steps in the release notes, so when updating Golar, don't forget to check for any major changes.

[BracketJohn]

Tested it out and it now successfully detects the artificially introduced problems 🎊

app/components/Offer/Page.vue:27:5 - error TS2367: This comparison appears to be unintentional because the types 'number' and 'string' have no overlap.

27 if (a === 'test') { // expected error 1: no overlap
       ~~~~~~~~~~~~

app/components/Offer/Page.vue:28:3 - error TS2322: Type 'Date' is not assignable to type 'number'.

28   a = new Date() // expected error 2: re-assignment to a different type
     ~

Sadly, it also detects a lot of other problems we didn't have before or that seem "empty" or wrong.

Example 1: Note how it suggest to use keep-alive, which is exactly what we are already using

layers/customer-module/app/components/CustomerModuleImage/CarouselFile.vue:49:7 - error TS2561: Object literal may only specify known properties, but 'keepAlive' does not exist in type 'MediaPlayerAttributes'. Did you mean to write 'keep-alive'?

49       keep-alive
         ~~~~~~~~~~

Example 2: Note how it (a) flags unused ts-expect-error directives and how (b) the error is "empty" (just a squigly line under no content with an "arbitrary" line number)

server/email/templates/de/ContactPersonWelcomeMail.vue:41:1 - error TS2578: Unused '@ts-expect-error' directive.

41 
   ~

server/email/templates/de/ContactSalesMail.vue:42:1 - error TS2578: Unused '@ts-expect-error' directive.

42 
   ~

server/email/templates/de/DefectAssignmentMail.vue:17:1 - error TS2578: Unused '@ts-expect-error' directive.

17 
   ~

server/email/templates/de/ExternalSalesMarketplaceErrorNotificationEmail.vue:22:1 - error TS2578: Unused '@ts-expect-error' directive.

22 
   ~

server/email/templates/de/ExternalStakeholderWelcomeMail.vue:52:1 - error TS2578: Unused '@ts-expect-error' directive.

52 
   ~

Example 3: Consola imports not found that were no problem with TS 5.9

shared/utils/logger.ts:1:15 - error TS2305: Module '"consola"' has no exported member 'ConsolaInstance'.

1 import type { ConsolaInstance, ConsolaOptions, ConsolaReporter, LogType } from 'consola'

---

Also, I'm curious how much faster Golar will run on your codebase compared to vue-tsc, so I'd appreciate it if you could share the results afterward. Thanks!

I'm very happy to do this once we got it running!

[auvred]

Oh, okay, let's try to resolve them then!

There can be several reasons for these errors:

• Differences between TS 5.9 and TS 7.0
• Different version of @vue/language-core
• Bug in Golar

Example 1: Note how it suggest to use keep-alive, which is exactly what we are already using

Could you share which version of vue-tsc you're using?

Also, it would be helpful if you can narrow this down to a small reproduction, so that I can iterate on it locally.

[BracketJohn]

Thanks, very helpful. Just let me know once/if this is too much of a burden to you (or stop completely without notice) - I know how much effort goes into maintaining OSS and this project is in ~pre-alpha state, so def. not in a place where I'd expect anything at all!

To get into it:

Could you share which version of vue-tsc you're using?

Yes: 3.2.4

❯ pnpm why vue-tsc
Legend: production dependency, optional only, dev only

devDependencies:
@vueuse/nuxt 14.1.0
└─┬ nuxt 4.2.2 peer
  └─┬ @nuxt/vite-builder 4.2.2
    └─┬ vite-plugin-checker 0.12.0
      └── vue-tsc 3.2.4 peer
nuxt 4.2.2
└─┬ @nuxt/vite-builder 4.2.2
  └─┬ vite-plugin-checker 0.12.0
    └── vue-tsc 3.2.4 peer
vue-tsc 3.2.4

Also, it would be helpful if you can narrow this down to a small reproduction, so that I can iterate on it locally.

I won't be able to do this, as the project is quite large & I have no effective way to reduce it down to a minimal reproduction given my current knowledge of what to look for. I naively tried to just "delete everything besides app.vue", but on the way there a lot of stuff breaks (eg: nuxt.config.ts relies on some of the deleted files).

To get a feeling for the size of the project I can share this, generated using scc:

❯ scc --exclude-dir pnpm-lock.yaml --exclude-dir node_modules
───────────────────────────────────────────────────────────────────────────────
Language                 Files     Lines   Blanks  Comments     Code Complexity
───────────────────────────────────────────────────────────────────────────────
Vue                       1228    140789    13938       800   126051       5080
TypeScript                 858    144618    14182      7597   122839      16952
SQL                        570     69420     3770      3623    62027         30
SVG                         53       133       10         0      123          0
JSON                        42     82278        0         0    82278          0
YAML                        10      1100      152        36      912          0
Markdown                     3       670      145         0      525          0
CSS                          2       450       73       140      237          0
JavaScript                   2       241       24        92      125          0
Docker ignore                1        10        0         0       10          0
Dockerfile                   1        64       18        16       30          5
Patch                        1        10        0         0       10          0
TOML                         1         3        0         2        1          0
TypeScript Typings           1        17        2         8        7          0
XML                          1       570        1         0      569          0
gitignore                    1        29        4         4       21          0
───────────────────────────────────────────────────────────────────────────────
Total                     2775    440402    32319     12318   395765      22067
───────────────────────────────────────────────────────────────────────────────

I could offer to hop on a quick call and debug in a screenshare or similar, if that'd be helpful? Then given your experience with typechecking-tooling we can maybe come up with an effective reproduction together.

Besides that I'd fully understand it if you don't want to proceed without a minimal repro, it's something we also enforce on our oss projects.

Hope that helps!

[auvred]

Language                 Files     Lines
────────────────────────────────────────
Vue                       1228    140789
TypeScript                 858    144618

Wow! It's huge, that's great! I wish there were public Vue 3.0 TS-based repos at that scale so I could test Golar on them...

I could offer to hop on a quick call and debug in a screenshare or similar, if that'd be helpful? Then given your experience with typechecking-tooling we can maybe come up with an effective reproduction together.

It would be great! I aim for Golar to fully compatible with vue-tsc, so this is a great chance for me to improve compatibility on a real-world project.

If you're on Discord, you can DM me there, my username is auvred. If not, what would be your preferred way to connect? (Note: I'll be available from tomorrow onward)

[BracketJohn]

Cool (: I sent you a friend request on discord, my username is bracketjohn. Let's continue coordination there, we should be able to figure something out!

[auvred]

@BracketJohn, I published golar@0.0.15 and @golar/vue@0.0.15. I was able to reproduce and fix the bug with the keep-alive prop. Unfortunately, I couldn't reproduce the "unused @ts-expect-error directive" errors, but I applied a fix that could potentially address them...

Also, I managed to reproduce the consola import errors. I'm not sure, but I vaguely remember that the logger.ts file is located in server directory, which has its own tsconfig.json. Maybe it contains deprecated module resolution settings.

I was able to reproduce the error with module: commonjs + moduleResolution: node. TS 5.9 doesn't report an error, but Golar does.

It turns out that moduleResolution: node is deprecated in TS 6.0 and removed in TS 7.0 (https://devblogs.microsoft.com/typescript/announcing-typescript-6-0-beta/#combining---moduleresolution-bundler-with---module-commonjs)

I was able to silence the error by setting module: preserve + moduleResolution: bundler or by using module: esnext. Since you're using Nuxt, I think module: preserve + moduleResolution: bundler is the better option.

Could you try running this new version of Golar and share your feedback? I hope the overall number of errors is much smaller now.

[adrienWeiss]

Hi,
I'm also testing Golar (0.0.15) on a very large private Vue JS codebase that we are progressively (and slowly) migrating to Vue TS.
Results are already very promising but we're also seeing a few discrepancies between vue-tsc (from CLI or Volar VSCode extension) and Golar. It seems very specific to the fact that we are currently in a state of Vue JS / Vue TS mixed codebase.

When an expression like a || b || (c && d) mixes any-typed values (e.g. from untyped getters) with a boolean comparison (d !== undefined), golar infers the result as Boolean (the wrapper object type) and rejects it when bound to a prop typed boolean | undefined. vue-tsc infers the same expression as boolean (the primitive) and accepts it.

The child component's props are defined using the Options API in a .vue file without lang="ts" (js by default in our case), so the prop types are inferred rather than explicitly declared — this may also contribute to the discrepancy.

The workaround is wrapping the expression with !!, but vue-tsc doesn't require this.

Like I said, it's probably highly specific to our codebase current state and I feel like Golar is actually right to raise the error, but since you aim to have full consistency with vue-tsc I figured you'd want to know about that.

In any case thank you for your work, I really hope this project gets the visibility it deserves, we've been waiting for the right tool to type-check our codebase in an efficient way