Support of puppetlabs-registry v2.0.x

[juju4]

Recent update of puppetlabs-registry (v2.0.x) breaks this module and reverting 1.1.4 breaks too many other modules.
What are the plan to update dependencies?

Thanks

https://ci.appveyor.com/project/juju4/puppet-meta-harden-windows/build/1.1.x.118?fullLog=true#L1199

Warning: Module 'puppetlabs-registry' (v2.0.2) fails to meet some dependencies:
  'autostructure-harden_windows_server' (v0.1.22) requires 'puppetlabs-registry' (>=1.1.4 < 2.0.0)
  'puppet-windows_autoupdate' (v2.0.0) requires 'puppetlabs-registry' (>= 1.1.1 < 2.0.0)
  'puppet-windows_eventlog' (v2.0.0) requires 'puppetlabs-registry' (>= 1.1.1 < 2.0.0)
Warning: Missing dependency 'ayohrling-local_security_policy':
  'autostructure-harden_windows_server' (v0.1.22) requires 'ayohrling-local_security_policy' (>=0.6.1 < 1.0.0)
Warning: Missing dependency 'jonono-auditpol':
  'autostructure-harden_windows_server' (v0.1.22) requires 'jonono-auditpol' (>=0.1.2 < 1.0.0)

or https://ci.appveyor.com/project/juju4/puppet-meta-harden-windows/build/1.1.x.117

Tested with puppet 5.4.0 and 5.5.0

[juju4]

seems ongoing work c961cb8
Thanks a lot!

[juju4]

almost working

• dependency issue

Warning: Module 'autostructure-auditpol' (v1.0.0) fails to meet some dependencies:
  'autostructure-harden_windows_server' (v0.1.23) requires 'autostructure-auditpol' (>1.0.0 < 2.0.0)

=> either >=1.0.0 in this repo or increase autostructure-auditpol version

• need release on github, puppet forge

[juju4]

even with dependency fix (juju4@1399272), still got error :(

https://ci.appveyor.com/project/juju4/puppet-meta-harden-windows/build/1.1.x.122?fullLog=true#L1185

puppet apply manifests/site.pp --disable_warnings deprecations --verbose
Info: Loading facts
Info: Loading facts
Info: Loading facts
Info: Loading facts
Info: Loading facts
Info: Loading facts
puppet : Error: Evaluation Error: Error while evaluating a Resource Statement, Could not find declared class ::local_security_policy (file: 
C:/ProgramData/PuppetLabs/code/environments/production/modules/harden_windows_server/manifests/configure.pp, line: 3, column: 3) on node appvyr-win
At line:1 char:1
+ puppet apply manifests/site.pp --disable_warnings deprecations --verb ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (Error: E... appvyr-win:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
 
Command executed with exception: Error: Evaluation Error: Error while evaluating a Resource Statement, Could not find declared class ::local_security_policy (file: C:/ProgramData/PuppetLabs/code/environments/production/modules/harden_windows_server/manifests/configure.pp, line: 3, column: 3) on node appvyr-win
puppet module list --tree
C:/ProgramData/PuppetLabs/code/environments/production/modules
├── ocastle-win_service (v0.0.10)
├─┬ puppet-archive (v3.1.1)
│ └── puppetlabs-stdlib (v4.25.1)
├── ipcrm-registry_acl (v0.0.5)
├─┬ puppet-windows_firewall (v1.0.3)
│ ├── puppetlabs-registry (v2.0.2)
│ └── liamjbennett-win_facts (v0.0.2)
├─┬ puppet-msoffice (v3.1.0)
│ └── puppetlabs-powershell (v2.1.5)
├─┬ puppetlabs-windows (v6.0.0)
│ ├── puppetlabs-acl (v2.0.1)
│ ├── puppetlabs-chocolatey (v3.0.0)
│ ├─┬ puppetlabs-dsc (v1.6.0)
│ │ └── puppetlabs-reboot (v2.0.0)
│ ├── puppetlabs-iis (v4.3.2)
│ ├── puppetlabs-wsus_client (v1.0.3)
│ ├── puppet-download_file (v3.1.0)
│ ├── puppet-windows_env (v3.1.0)
│ └── puppet-windowsfeature (v3.2.0)
└─┬ autostructure-harden_windows_server (v0.1.23)
  ├── kpn-local_security_policy (v3.1.1)
  └── autostructure-auditpol (v1.0.0)
C:/ProgramData/PuppetLabs/code/modules (no modules installed)

[jessereynolds]

@juju4 how much of a blocker is this dependency issue for you? Have you worked around it somehow?

[juju4]

I managed to make workaround but I installed module as tar.gz as no updated fixed release in puppet registry

fork compare, removed class line
master...juju4:master#diff-74f6505d89258111eb6c4102dfc94b72L3

latest build
https://ci.appveyor.com/project/juju4/harden-windows-server
still error but executing

Error: /Stage[main]/Harden_windows_server::Configure/Local_security_policy[Deny access to this computer from the network]: Could not evaluate: Execution of 'C:/Windows/system32/SecEdit.exe /configure /db 
c:\windows\temp\sdbimport-20190429212056.inf /cfg c:\windows\temp\infimport-20190429212056.inf' returned 1: Completed 1 percent (0/63) 	Process Privilege Rights area        
At line:1 char:1
+ puppet apply -e "include ::harden_windows_server" --disable_warnings  ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (Error: /...ts area        :String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
 
Completed 3 percent (1/63) 	Process Privilege Rights area        Completed 4 percent (2/63) 	Process Privilege Rights area        Completed 6 percent (3/63) 	Process Privilege Rights area        Completed 7 percent (4/63) 	
Process Privilege Rights area        Completed 25 percent (15/63) 	Process Privilege Rights area        Completed 25 percent (15/63) 	Process Group Membership area        Completed 49 percent (30/63) 	Process Group Membership 
area        Completed 49 percent (30/63) 	Process Registry Keys area        Completed 49 percent (30/63) 	Process File Security area        Completed 49 percent (30/63) 	Process Services area        Completed 65 percent (40/63) 	
Process Services area        Completed 73 percent (45/63) 	Process Services area        Completed 73 percent (45/63) 	Process Security Policy area        Completed 77 percent (48/63) 	Process Security Policy area        
Completed 84 percent (52/63) 	Process Security Policy area        Completed 88 percent (55/63) 	Process Security Policy area        Completed 93 percent (58/63) 	Process Security Policy area        Completed 100 percent (63/63) 	
Process Security Policy area                                                                                   
No mapping between account names and security IDs was done.
The task has completed with an error.
See log %windir%\security\logs\scesrv.log for detail info.