Skip to content

An error found in influence-models #83

@WenqianZhao

Description

@WenqianZhao

In influence_models.py line 115, the code is:
tmp_used = used[:i] + used[i:]
This line doesn't remove the ith element in used, maybe what you really want is sth like:
tmp_used = used[:i] + used[i+1:]
and also need to check whether i+1 is out of range.
For now, because 'tmp_used' is the same as 'used', backward pass actually did nothing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions