SASS support

[kidoman]

I was looking through the past issues/commits and see that we removed SASS support. Any particular reason why?

[kidoman]

So is atomify-css not recommended for people wanting to use SASS? I mean, if the library supports less could sass also not be supported cleanly? @bclinkinbeard

[bclinkinbeard]

No, the problem with sass is it relies on a native implementation that has to be built on each platform during installation. That build step was deemed slow/annoying, so we removed it.

On Sat, Jul 12, 2014 at 11:41 AM, Karan Misra notifications@github.com
wrote:

So is atomify-css not recommended for people wanted to use SASS? I mean, if the library supports less could sass also not be supported cleanly?

Reply to this email directly or view it on GitHub:
#17 (comment)

[kidoman]

If we could make the requirement for the sass component optional (for only those who care about it), would that work?

[bclinkinbeard]

That isn't how optionalDependencies work, unfortunately. optionalDependencies just mean that an install will not fail if they cannot be found. If there were an easy way to make SASS support truly opt-in we'd likely be open to it, but I don't know if that is actually possible.

[techwraith]

We would take a PR that allowed people to use SASS without requiring it to be installed by everyone. Geddy does this for the various templating languages that it supports. It checks the local node_modules directory to see if the package exists before trying to require it.

[kidoman]

@techwraith that is precisely what I had in mind. I have also seen the same technique being used by sequilize for supporting MySQL, MariaSQL, Postgres, etc.

[kidoman]

This is what I had in mind: https://github.com/sequelize/sequelize/blob/master/lib/dialects/mysql/connection-manager.js#L13

I can send in a PR if this solution is deemed acceptable

[bclinkinbeard]

Browserify does not support dynamic require paths so that approach wouldn't work.

On Sat, Jul 12, 2014 at 3:13 PM, Karan Misra notifications@github.com
wrote:

This is what I had in mind: https://github.com/sequelize/sequelize/blob/master/lib/dialects/mysql/connection-manager.js#L13

I can send in a PR if this solution is deemed acceptable

Reply to this email directly or view it on GitHub:
#17 (comment)

[kidoman]

@bclinkinbeard what does this have to do with browserify ? I thought that was in atomify-js?

Please help me understand?

[techwraith]

Yeah, I don't think this has anything to do with browserify. This is all
happening in node land so we should be fine.

On Saturday, July 12, 2014, Karan Misra notifications@github.com wrote:

@bclinkinbeard https://github.com/bclinkinbeard what does this have to
do with browserify ? I thought that was in atomify-js?

Please help me understand?

—
Reply to this email directly or view it on GitHub
#17 (comment).

[bclinkinbeard]

You're both right, I replied too quickly. My bad.

[kidoman]

@bclinkinbeard Thanks for the confirmation. Will send the PR in shortly

[ckundo]

@kidoman where did you end up with the PR? @stubbornella and I started on an implementation, but it is incomplete. We're not sure how to make the @import statements look in node_modules/ ckundo@1ec4feb

Perhaps @techwraith @kidoman @bclinkinbeard one of you might take a look and comment?