Field name "string" colored same as type name "string"

[ramya-rao-a]

From @willfaught on September 20, 2017 6:7

As in:

type foo struct {
    name, packageName, packagePath, string string
}

Screenshot:

Is there a way to color the token "string" based on the parsing context?

Copied from original issue: microsoft/vscode-go#1230

[ramya-rao-a]

Am curious, why would you want to name a struct field the same as a keyword?

Feels idiomatically wrong...

cc @rakyll and @campoy for thoughts.

[ramya-rao-a]

From @willfaught on September 24, 2017 20:0

The fields matched exported method names in another type. In this case, String() string.

Another common one is “len”. Also “cap”.

Sent from my iPhone

On Sep 23, 2017, at 11:23 PM, Ramya Rao notifications@github.com wrote:

Am curious, why would you want to name a struct field the same as a keyword?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[ramya-rao-a]

The words in white have the scope source.go
The string has the scope storage.type.string.go

The same issue occurs in Atom as well

[willfaught]

Am curious, why would you want to name a struct field the same as a keyword?

Note that string isn't a keyword in the parsing sense; it's a pre-declared identifier that can be re-declared. Same with int, len and cap. This issue applies to the identifiers of all built-in types: int8, uintptr, rune, etc.

[ramya-rao-a]

Thanks for the clarification @willfaught , I get it now.

[rakyll]

The reserved keywords are listed at https://golang.org/ref/spec#Keywords. Everything else can be used as an identifier. Even though it may not sound as a good option to call an identifier "string", it is not illegal.

[ramya-rao-a]

Thanks @rakyll