-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Background
Identified during PR #27 review as out-of-scope enhancement.
Original Review Comment:
G2: Consider adding upload success logging (low priority)
Location: .github/workflows/deploy.yml (upload section)
Scope
Add logging for successful file uploads during deployment to improve debugging and visibility into the deploy process.
Suggested Implementation
After each successful upload (HTTP 200/201), log:
- File path uploaded
- Target bucket path
- Response status
Example:
if [[ "$HTTP_STATUS" =~ ^2 ]]; then
echo "✓ Uploaded: $file → $BUCKET_PATH"
fiAcceptance Criteria
- Log successful uploads with file path
- Include in both deploy.yml and deploy-dry-run.yml
- Keep output clean (consider verbosity flag)
References
- PR fix(deploy): use REST API for uploads to control MIME types #27: fix(deploy): use REST API for uploads to control MIME types #27
- Related to deployment workflow improvements
Created from PR #27 review triage
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request