RescueSystem.activate() is missing authorized_keys parameter in 0.8.3?

[saz]

I've installed the newest release from pypi and RescueSystem.activate() seems to lack the authorized_keys parameter.

In master, everything's looking good:

hetzner/hetzner/server.py

Line 103 in 0c9c313

def activate(self, bits=64, os='linux', authorized_keys=None):

Downloaded 0.8.3 from pypi and the activate method of RescueSystem is in line 94?

[cyberplant]

+1 to this issue, I've just reinstalled hetzner package from pip and doesn't have the authorized_keys part that it's currently on master. What is going on? maybe the CI/CD is pointing to a wrong version?

To check also downloaded the hetzner-0.8.3.tar.gz file from pypi:

$ tar xvfj hetzner-0.8.3.tar.gz
x hetzner-0.8.3/
x hetzner-0.8.3/PKG-INFO
x hetzner-0.8.3/hetzner/
x hetzner-0.8.3/hetzner/__init__.py
x hetzner-0.8.3/hetzner/failover.py
x hetzner-0.8.3/hetzner/rdns.py
x hetzner-0.8.3/hetzner/reset.py
x hetzner-0.8.3/hetzner/robot.py
x hetzner-0.8.3/hetzner/server.py
x hetzner-0.8.3/hetzner/tests/
x hetzner-0.8.3/hetzner/tests/__init__.py
x hetzner-0.8.3/hetzner/tests/test_util_addr.py
x hetzner-0.8.3/hetzner/util/
x hetzner-0.8.3/hetzner/util/__init__.py
x hetzner-0.8.3/hetzner/util/addr.py
x hetzner-0.8.3/hetzner/util/http.py
x hetzner-0.8.3/hetzner/util/scraping.py
x hetzner-0.8.3/hetznerctl
x hetzner-0.8.3/setup.py
$ cd hetzner-0.8.3/hetzner
hetzner-0.8.3/hetzner $ grep authorized server.py
hetzner-0.8.3/hetzner $

[The-Judge]

OK, this seems to be open for quite some time now ... 2 years 3 months no reaction even ...
I noticed that this project seems to have quite a strange (defect?) release technique and took some time to scan through the code:

• The master branch contains the authorized_keys parameter but does not seem to be what's latest on PyPi.org (0.8.3) since, as you guys pointed out, PiPy.org version does not have the authorized_keys parameter, (amongst other differences)
• There is only one Release here on GitHub, which is 0.8.0 from 2017
• There are Git Tags, however, of the same release versions as those on PyPi. The most recent one (0.8.3) also does not have that authorized_keys parameter: 6635db2
• Parameter authorized_keys was added with fbfc33d, end of October 2018 and got merged into master on Nov 21, 2018 already. Tag 0.8.3 has been created on Jan 11, 2021, but in branch origin/release-0.8, which has been split from master just before these changes got introduced. That way, this change (any many after that, which all flew into master) never made it to the official PyPi release:

I don't know what's the plan here exactly ... but for now, without a propper, official release for PyPi, you can only stick to PyPi's version 0.8.3 (without the parameter authorized_keys) or use master branch to install the module.
If you choose the later, in pipenv this works like that:

[packages]
hetzner = {git = "https://github.com/aszlig/hetzner.git", editable = true, ref = "master"}

or, if you do not receive updates as soon there is new stuff added to master and stick with the current state of master instead:

[packages]
hetzner = {git = "https://github.com/aszlig/hetzner.git", editable = true, ref = "e9f802c7b37a23efa3e6411364a5333c9c956258"}

or, if you just want 0.8.3 with that authorized_keys parameter:

[packages]
hetzner = {git = "https://github.com/aszlig/hetzner.git", editable = true, ref = "0c9c3130f300fd6c590a31b4aa6027e7b4325d1a"}