Directly override the pdfJsViewer plugin version of pdf.js

[ctgraham]

Nobody wants to:

To apply it...

cd plugins/generic/pdfJsViewer/pdf.js
patch -p2 < /path/to/ab3f25.diff

[asmecher]

There are different instructions in the master branch README, since Hypothes.is recently updated their package and no longer have a single commit that'll turn a non-Hypothes.is-enabled pdf.js into a Hypothes.is-enabled one. But this part of the issue still applies:

Nobody wants to

However, I'm not sure about just shipping this plugin with the hypothes.is alterations included, as it would seem that the Hypothes.is plugin should do that. On the flip side, it's not clear to me how to allow the Hypothes.is plugin to intervene in this plugin's behaviour gracefully. I'm open to ideas.

[asmecher]

@ctgraham answers my question at the moment I finish asking it :) https://github.com/asmecher/hypothesis/pull/11/files

[ctgraham]

@asmecher, are you also cherry-picking to master, or do you want to get the PR I've almost formulated?

Note that I have not tested this against 3.2.