Avoid a unecessary allocation in has_same_children_properties

alamb · alamb · commit 22470d50f70d · 2026-02-24T09:05:05.000-05:00
diff --git a/datafusion/physical-plan/src/execution_plan.rs b/datafusion/physical-plan/src/execution_plan.rs
@@ -1436,7 +1436,7 @@ pub fn has_same_children_properties(
         old_children.len(),
         "Wrong number of children"
     );
-    for (lhs, rhs) in plan.children().iter().zip(children.iter()) {
+    for (lhs, rhs) in old_children.iter().zip(children.iter()) {
         if !Arc::ptr_eq(lhs.properties(), rhs.properties()) {
             return Ok(false);
         }

Original file line number	Diff line number	Diff line change
`@@ -1436,7 +1436,7 @@ pub fn has_same_children_properties(`
`1436`	`1436`	`old_children.len(),`
`1437`	`1437`	`"Wrong number of children"`
`1438`	`1438`	`);`
`1439`		`- for (lhs, rhs) in plan.children().iter().zip(children.iter()) {`
	`1439`	`+ for (lhs, rhs) in old_children.iter().zip(children.iter()) {`
`1440`	`1440`	`if !Arc::ptr_eq(lhs.properties(), rhs.properties()) {`
`1441`	`1441`	`return Ok(false);`
`1442`	`1442`	`}`