Restricting methods with <package>.<type>.<method> doesn't work if return value is directly accessed

[dejan-lokar]

I'm using the linter to restrict the GORM Raw method. I run the linter with golangci-lint 1.53.2. The forbidigo configuration is:

  forbidigo:
    analyze-types: true
    forbid:
      - p: gorm.DB.Raw
        msg: Example message.

Running the linter on the following example code it recognizes the first two instances but not the last one:

	var db *gorm.DB
	_ = db.Raw("...")
	_ = db.Session(nil).Raw("...")
	_ = db.Raw("...").Error

[ashanbrown]

Thanks for the report @dejan-lokar. I think this is the issue I called out when reviewing the new bheavior at #21 (comment) and part of the reason I'd consider analyze_types to be "experimental". @pohly any thoughts on how we could support this case? Looking at the response to that comment, there does seem to be suggestion that this case should be supported.

[pohly]

I'll have a look.

[ashanbrown]

Thanks @pohly . I missed your comment. I've merged a fix for this but please let me know if there are other cases we might not be accounting for. As part of my fix, I'm also preventing us from matching receiver names without including the receiver type, which seemed like the desirable behavior to me, but please let me know if you think I might be missing some cases.

[pohly]

Your PR looks good to me.

[ashanbrown]

Great, thanks for taking a look @pohly .