Two sources of truth for TEA version

[reweeden]

Because of how we manage the version number, if you deploy one version of the code zip with a different version of the cloudformation.yaml you will get differing version numbers in the logs than you do from the /version endpoint. This is because the version from the version endpoint is baked into the source code by the Makefile while the version from the logs is pulled from the environment which is set in the cloudformation.yaml.

Probably we should not be setting the environment variable from the cloudformation. The tricky thing is that the version in the logs is set by rain-api-core here: https://github.com/asfadmin/rain-api-core/blob/5a62aa1d767e9a0efd5e7ccb2dd2260d0503582a/rain_api_core/logging.py#L202 so we would need to figure out an alternate way to pass that version number in.