suggested enhancement to display before and after fields

[fossfreedom]

As it stands - the plugin is superb - it fixed a whole bunch of weird stuff I had and responded to some really duff stuff very well.

Brilliant :D

Maybe on a wet-weekend when you are bored - perhaps you may like to consider the following:

in the finger print dialog - display the before and after fields i.e. artist name before and artist name after etc.

When you click the extra info - maybe expand the window to show these extra fields.

If you feel adventurous - maybe even allow people to "checkbox" click those fields you want to update, and those fields you dont want to update.

Anyway - superb plugin.

I'm now going to work out how to package v0.6 of pylast - thanks for your previous link - I'll see if these still work when packaging.

[asermax]

Thank you very much for the support foss :3 and thank you for the suggestions, I'll implement some of these things when I got some time, but first I think I will be refactoring the whole plugin to make it more maintainable (right now it works, but I would like to make it more object oriented and easily extensible).

Anyway, some thoughts about your sugestions:

• The before and after fields, you say like an extra confirmation dialog showing the changes? Or instead of using buttons, putting that info for each option? I don't want to be repetitive, showing the same data everywhere, but if you give me a better image of what your idea is, I may implement it.
• The thing about the extra fields is that they have to be retrieved separtedly from the initial info, which means making more request against LastFM and more dead time, that's why I use an asynchronous call in the background. And each option may have different extra-info. What I can do is, when selecting the checkbox, add another spinner to indicate the data is being fetched, and show it on the dialog once retrieved. Once there, the user could save the whole thing. Is that what you had in mind?
• Regarding the third suggestion (and kinda involving the previous one too), I was thinking of adding another extension to my plugin, once I'm done with the refactoring; this extension would add another tab to the poperties dialog of an entry, allowing to compare your current metadata with the one retrieved from LastFM, and let you replace ONLY the fields you think are wrong on your side. If I come to implement that, that would leave the fingerprinting extension as a tool to identify totally unknown tracks, and this new extension as a tool to fix entries metadata.

Anyway, I'll leave this issue open for now as a reminder of this suggestions, but we should probably create individual issues for each feature once we shape them better.

[fossfreedom]

ok - I'm the worlds worst artist...

maybe this picture will help

http://i.imgur.com/juD3P.png

Re second point - ok understand the issue here - assuming you've understood my picture - the extra info fields at the bottom willl only appear if you select the checkbox (not shown) "get extra info"

[asermax]

Heh, the picture is understandable, don't worry.
Well, that is somehow what I was thinking for the new extension, but seems like a good idea to add it to the fingerprinting feature too. I will work on it when I got some time, I'll update this issue when I make some progress :3