Skip to content

Commit ceb302e

Browse files
aryadiansaryadians
committed
polish UI
1 parent 4f8da4e commit ceb302e

21 files changed

Lines changed: 1621 additions & 1239 deletions

‎TESTING_REPORT.md‎

Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
# Testing Report - SIMPEG Lapas
2+
3+
**Date:** 2026-02-16
4+
**Tester:** Gemini CLI Agent
5+
6+
## 1. Test Environment
7+
- **OS:** Win32
8+
- **PHP Version:** 8.2 (Simulated)
9+
- **Database:** SQLite (:memory:) for automated tests.
10+
- **Framework:** Laravel 12.x / Livewire 4.x
11+
12+
## 2. Automated Tests (PHPUnit)
13+
14+
All automated tests passed successfully after fixes.
15+
16+
| Test Suite | Test Case | Status | Notes |
17+
| :--- | :--- | :--- | :--- |
18+
| **Authentication** | `login_screen_can_be_rendered` | ✅ PASS | |
19+
| | `users_can_authenticate` | ✅ PASS | |
20+
| | `users_cannot_authenticate_invalid` | ✅ PASS | |
21+
| **Roster** | `dashboard_can_render` | ✅ PASS | |
22+
| | `roster_data_is_visible` | ✅ PASS | Fixed role constraint issue (`role='staff'`). |
23+
| | `admin_can_generate_schedule` | ✅ PASS | Verified bulk insert logic. |
24+
| | `non_admin_cannot_generate` | ✅ PASS | Verified authorization gate. |
25+
| **Attendance** | `user_can_clock_in_within_radius` | ✅ PASS | Fixed date parsing bug & mocked time to ensure 'hadir' status. |
26+
| | `user_cannot_clock_in_outside_radius` | ✅ PASS | Verified geofencing logic. |
27+
| **General** | `application_returns_successful_response` | ✅ PASS | Updated to expect redirect (302) for guest users. |
28+
29+
## 3. Manual / Code Analysis Verification
30+
31+
### A. Navigation & Links
32+
- **Navigation Bar:** Verified in `resources/views/components/layouts/app.blade.php`. All links point to valid routes.
33+
- **Mobile Menu:** Consistent with desktop menu.
34+
- **Route Names:** Validated against `routes/web.php`.
35+
36+
### B. Critical Features Code Review
37+
38+
#### 1. Attendance (Geofencing & Selfie)
39+
- **Status:** **FIXED**
40+
- **Issue:** The `AttendanceWidget` expected an `UploadedFile` but the frontend sends a Base64 string from the canvas.
41+
- **Fix:** Updated `AttendanceWidget.php` to handle Base64 decoding manually and updated validation rules.
42+
- **Verification:** Logic now supports both `UploadedFile` (for tests) and Base64 string (for real usage).
43+
44+
#### 2. Admin Dashboard
45+
- **Status:** **FIXED**
46+
- **Issue:** `presentToday` calculation used non-existent column `check_in_time`.
47+
- **Fix:** Changed to use `date` column which aligns with the migration.
48+
49+
#### 3. Roster Generation
50+
- **Status:** **Verified**
51+
- **Logic:** `RosterDashboard::generateSchedule` correctly deletes old rosters for the month and generates new ones based on a pattern.
52+
- **Security:** Properly checks for `admin` role.
53+
54+
#### 4. Login UI
55+
- **Status:** **Verified**
56+
- **UI:** Login page includes CSRF protection (via Livewire) and error feedback.
57+
58+
## 4. Recommendations
59+
1. **Frontend Testing:** Consider adding Laravel Dusk or Cypress for true E2E testing of the camera/geolocation features which are hard to mock in PHPUnit.
60+
2. **Date/Time Handling:** The system relies heavily on `Carbon::now()`. Ensure the server timezone is correctly set in `config/app.php`.
61+
3. **Validation:** Add stricter validation for the Base64 image string to ensure it's a valid image.
62+
63+
## 5. Conclusion
64+
The application's core features (Authentication, Roster, Attendance, Dashboard) are functional and tested. Critical bugs in the attendance submission and dashboard statistics have been resolved.

‎app/Livewire/AdminDashboard.php‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
use App\Models\IncidentReport;
1010
use App\Models\Inventory;
1111
use App\Models\Attendance;
12+
use App\Models\Roster;
1213
use Carbon\Carbon;
1314

1415
class AdminDashboard extends Component
@@ -31,8 +32,8 @@ public function mount()
3132
$this->pendingLeaveRequests = LeaveRequest::where('status', 'pending')->count();
3233
$this->recentIncidents = IncidentReport::where('created_at', '>=', Carbon::now()->subHours(24))->count();
3334
$this->overdueInventory = Inventory::where('status', 'checked_out')->whereNotNull('due_at')->where('due_at', '<', Carbon::now())->count();
34-
$this->presentToday = Attendance::whereDate('check_in_time', Carbon::today())->count();
35-
$this->onDutyToday = \App\Models\Roster::where('date', Carbon::today())->distinct('user_id')->count();
35+
$this->presentToday = Attendance::whereDate('date', Carbon::today())->count();
36+
$this->onDutyToday = Roster::whereDate('date', Carbon::today())->distinct('user_id')->count();
3637
}
3738

3839
public function render()

‎app/Livewire/AttendanceWidget.php‎

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
use Carbon\Carbon;
99
use Illuminate\Support\Facades\Auth;
1010
use Livewire\WithFileUploads;
11+
use Illuminate\Support\Facades\Storage;
12+
use Illuminate\Support\Str;
1113

1214
class AttendanceWidget extends Component
1315
{
@@ -28,7 +30,7 @@ class AttendanceWidget extends Component
2830
public $selfie;
2931

3032
protected $rules = [
31-
'selfie' => 'required|image|max:5120', // 5MB Max
33+
'selfie' => 'required', // Allow string (base64) or UploadedFile
3234
];
3335

3436
public function mount($todayRoster = null)
@@ -141,7 +143,22 @@ public function confirmClockIn()
141143
$status = 'terlambat';
142144
}
143145

144-
$selfiePath = $this->selfie->store('selfies', 'public');
146+
$selfiePath = '';
147+
148+
if (is_string($this->selfie) && strpos($this->selfie, 'data:image') === 0) {
149+
// Handle Base64
150+
$image = str_replace('data:image/jpeg;base64,', '', $this->selfie);
151+
$image = str_replace(' ', '+', $image);
152+
$imageName = 'selfies/' . Str::random(40) . '.jpg';
153+
Storage::disk('public')->put($imageName, base64_decode($image));
154+
$selfiePath = $imageName;
155+
} elseif ($this->selfie instanceof \Illuminate\Http\UploadedFile) {
156+
// Handle UploadedFile (Testing)
157+
$selfiePath = $this->selfie->store('selfies', 'public');
158+
} else {
159+
$this->addError('selfie', 'Format foto tidak valid.');
160+
return;
161+
}
145162

146163
Attendance::create([
147164
'user_id' => Auth::id(),
@@ -180,4 +197,4 @@ public function render()
180197
{
181198
return view('livewire.attendance-widget');
182199
}
183-
}
200+
}

‎resources/views/components/layouts/app.blade.php‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,28 @@
3737
70% { opacity: 1; transform: scale(1.1); }
3838
100% { transform: scale(1); }
3939
}
40+
41+
/* Global Custom Scrollbar */
42+
::-webkit-scrollbar {
43+
width: 8px;
44+
height: 8px;
45+
}
46+
::-webkit-scrollbar-track {
47+
background: #f1f5f9;
48+
}
49+
::-webkit-scrollbar-thumb {
50+
background: #cbd5e1;
51+
border-radius: 10px;
52+
}
53+
::-webkit-scrollbar-thumb:hover {
54+
background: #94a3b8;
55+
}
56+
57+
/* Selection Color */
58+
::selection {
59+
background: #4f46e5;
60+
color: white;
61+
}
4062
</style>
4163

4264
<script>

0 commit comments

Comments
 (0)