From 3aac8a863ee843bea18e1585ba598a3ab6b82254 Mon Sep 17 00:00:00 2001
From: MarkoWystrach <marko.wystrach@artemeon.de>
Date: Mon, 1 Sep 2025 12:36:52 +0200
Subject: [PATCH 1/4] #26672: Add image captions

---
 .../ImageAndVideoMacroReplacer.php            | 94 ++++++++++---------
 1 file changed, 50 insertions(+), 44 deletions(-)

diff --git a/src/MacroReplacer/ImageAndVideoMacroReplacer.php b/src/MacroReplacer/ImageAndVideoMacroReplacer.php
index a52b96e..a54edf8 100755
--- a/src/MacroReplacer/ImageAndVideoMacroReplacer.php
+++ b/src/MacroReplacer/ImageAndVideoMacroReplacer.php
@@ -1,44 +1,50 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Artemeon\Confluence\MacroReplacer;
-
-/**
- * Ersetze <ac:image> durch HTML <img> oder <video> Tags, abhängig vom Dateityp
- */
-class ImageAndVideoMacroReplacer implements MacroReplacerInterface
-{
-    private string $sourceFolder;
-
-    public function __construct(string $sourceFolder = '')
-    {
-        if (!str_ends_with($sourceFolder, '/')) {
-            $sourceFolder .= '/';
-        }
-
-        $this->sourceFolder = $sourceFolder;
-    }
-
-    public function replace(string $haystack): string
-    {
-        return preg_replace_callback(
-            '/<ac:image[^>]*>.*?<ri:attachment\s+ri:filename="([^"]+)"[^>]*>.*?<\/ac:image>/is',
-            function ($match) {
-                $attachmentFileName = $match[1];
-                $fileExtension = pathinfo($attachmentFileName, PATHINFO_EXTENSION);
-
-                //Distinguish between images and videos
-                if (in_array($fileExtension, ['jpg', 'jpeg', 'png', 'gif'])) {
-                    return '<img src="' . $this->sourceFolder . $attachmentFileName . '">';
-                } elseif (in_array($fileExtension, ['mp4', 'avi', 'mkv', 'mov'])) {
-                    return '<video controls><source src="' . $this->sourceFolder . $attachmentFileName . '" type="video/' . $fileExtension . '">Your browser does not support the video tag.</video>';
-                } else {
-                    // By default, a link to the attachment is created
-                    return '<a href="' . $this->sourceFolder . $attachmentFileName . '">' . $this->sourceFolder . $attachmentFileName . '</a>';
-                }
-            },
-            $haystack
-        );
-    }
-}
+<?php
+
+declare(strict_types=1);
+
+namespace Artemeon\Confluence\MacroReplacer;
+
+/**
+ * Ersetze <ac:image> durch HTML <img> oder <video> Tags, abhängig vom Dateityp
+ */
+class ImageAndVideoMacroReplacer implements MacroReplacerInterface
+{
+    private string $sourceFolder;
+
+    public function __construct(string $sourceFolder = '')
+    {
+        if (! str_ends_with($sourceFolder, '/')) {
+            $sourceFolder .= '/';
+        }
+
+        $this->sourceFolder = $sourceFolder;
+    }
+
+    public function replace(string $haystack): string
+    {
+        return preg_replace_callback(
+            '/<ac:image[^>]*>.*?<ri:attachment\s+ri:filename="([^"]+)"[^>]*>.*?(?:<ac:caption>(.*?)<\/ac:caption>)?.*?<\/ac:image>/is',
+            function ($match) {
+                $attachmentFileName = $match[1];
+                $caption = isset($match[2]) ? trim($match[2]) : '';
+                $fileExtension = pathinfo($attachmentFileName, PATHINFO_EXTENSION);
+
+                // Distinguish between images and videos
+                if (in_array($fileExtension, ['jpg', 'jpeg', 'png', 'gif'])) {
+                    $imgTag = '<img src="'.$this->sourceFolder.$attachmentFileName.'" alt="could not load image">';
+                    if ($caption !== '') {
+                        return '<figure>'.$imgTag.'<figcaption class="text-center">'.$caption.'</figcaption></figure>';
+                    }
+
+                    return $imgTag;
+                } elseif (in_array($fileExtension, ['mp4', 'avi', 'mkv', 'mov'])) {
+                    return '<video controls><source src="'.$this->sourceFolder.$attachmentFileName.'" type="video/'.$fileExtension.'">Your browser does not support the video tag.</video>';
+                } else {
+                    // By default, a link to the attachment is created
+                    return '<a href="'.$this->sourceFolder.$attachmentFileName.'">'.$this->sourceFolder.$attachmentFileName.'</a>';
+                }
+            },
+            $haystack
+        );
+    }
+}

From 9b57c05d593e0faef1ca7ffccca23588adb60bf3 Mon Sep 17 00:00:00 2001
From: MarkoWystrach <marko.wystrach@artemeon.de>
Date: Mon, 1 Sep 2025 14:38:34 +0200
Subject: [PATCH 2/4] #26672: remove tailwind styling, add filename as alt

---
 src/MacroReplacer/ImageAndVideoMacroReplacer.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/MacroReplacer/ImageAndVideoMacroReplacer.php b/src/MacroReplacer/ImageAndVideoMacroReplacer.php
index a54edf8..59f5d9c 100755
--- a/src/MacroReplacer/ImageAndVideoMacroReplacer.php
+++ b/src/MacroReplacer/ImageAndVideoMacroReplacer.php
@@ -31,9 +31,9 @@ function ($match) {
 
                 // Distinguish between images and videos
                 if (in_array($fileExtension, ['jpg', 'jpeg', 'png', 'gif'])) {
-                    $imgTag = '<img src="'.$this->sourceFolder.$attachmentFileName.'" alt="could not load image">';
+                    $imgTag = '<img src="'.$this->sourceFolder.$attachmentFileName.'" alt="'.htmlspecialchars($attachmentFileName, ENT_QUOTES).'">';
                     if ($caption !== '') {
-                        return '<figure>'.$imgTag.'<figcaption class="text-center">'.$caption.'</figcaption></figure>';
+                        return '<figure>'.$imgTag.'<figcaption>'.$caption.'</figcaption></figure>';
                     }
 
                     return $imgTag;

From 8bc945e111dc99ef20686c43d440d4cd244b83a9 Mon Sep 17 00:00:00 2001
From: MarkoWystrach <marko.wystrach@artemeon.de>
Date: Mon, 1 Sep 2025 14:45:13 +0200
Subject: [PATCH 3/4] #26672: css center text

---
 src/MacroReplacer/ImageAndVideoMacroReplacer.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/MacroReplacer/ImageAndVideoMacroReplacer.php b/src/MacroReplacer/ImageAndVideoMacroReplacer.php
index 59f5d9c..da3aa4a 100755
--- a/src/MacroReplacer/ImageAndVideoMacroReplacer.php
+++ b/src/MacroReplacer/ImageAndVideoMacroReplacer.php
@@ -33,7 +33,7 @@ function ($match) {
                 if (in_array($fileExtension, ['jpg', 'jpeg', 'png', 'gif'])) {
                     $imgTag = '<img src="'.$this->sourceFolder.$attachmentFileName.'" alt="'.htmlspecialchars($attachmentFileName, ENT_QUOTES).'">';
                     if ($caption !== '') {
-                        return '<figure>'.$imgTag.'<figcaption>'.$caption.'</figcaption></figure>';
+                        return '<figure>'.$imgTag.'<figcaption style="text-align: center;">'.$caption.'</figcaption></figure>';
                     }
 
                     return $imgTag;

From 64ccef37062f8ac0d71813f7e106d1b33c6ca909 Mon Sep 17 00:00:00 2001
From: MarkoWystrach <marko.wystrach@artemeon.de>
Date: Tue, 9 Sep 2025 12:48:32 +0200
Subject: [PATCH 4/4] Update src/MacroReplacer/ImageAndVideoMacroReplacer.php
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Felix Küchler <42901831+f-kuechler@users.noreply.github.com>
---
 src/MacroReplacer/ImageAndVideoMacroReplacer.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/MacroReplacer/ImageAndVideoMacroReplacer.php b/src/MacroReplacer/ImageAndVideoMacroReplacer.php
index da3aa4a..bc2900a 100755
--- a/src/MacroReplacer/ImageAndVideoMacroReplacer.php
+++ b/src/MacroReplacer/ImageAndVideoMacroReplacer.php
@@ -5,7 +5,7 @@
 namespace Artemeon\Confluence\MacroReplacer;
 
 /**
- * Ersetze <ac:image> durch HTML <img> oder <video> Tags, abhängig vom Dateityp
+ * Replace <ac:image> with HTML <img> or <video> tags, depending on the file type
  */
 class ImageAndVideoMacroReplacer implements MacroReplacerInterface
 {