-
Notifications
You must be signed in to change notification settings - Fork 1
Description
Describe the bug
A SIP package is comprised of the directory of content (the SIP) and its container (the ZIP). While it's likely that both the SIP and the ZIP would have the same name, this isn't enforced. The problem is that while the naming convention check is done on the SIP, it is not done on the ZIP, but the ZIP name is the one that is used throughout Enduro, including for the resulting AIP. This could result in AIPs that have non-conformant names, which undermines the purpose of the naming check.
To Reproduce
Steps to reproduce the behavior:
- Create a SIP with a conformant name
- Compress the SIP, and then change the name of the resulting ZIP package
- Upload the SIP package to Enduro and review the resulting AIP
In this example, my SIP has a conventional name - SIP_20250101_Vecteur_785934. I compressed it and then renamed the ZIP to getthatbutter.zip (sorry for the stupid name 🫠)
The SIP and the resulting AIP both have the name of my ZIP, rather than the name of the SIP.
Expected behavior
There are a few different ways we could tackle this. Either the system could check to ensure that the SIP and ZIP names are the same, or it could use the SIP name exclusively. In any case, the following principles should apply:
- The SIP name is conformant with the naming convention rules, if they exist
- The SIP name is used throughout the application
- The resulting AIP uses the SIP name
