Think about how to resolve: This has to be the scariest parameter list I have ever seen. Consider passing by value or const ref to allow the compiler to make optimizations and avoid undefined behavior when things go out of scope.

[rrivera747]

This has to be the scariest parameter list I have ever seen. Consider passing by value or const ref to allow the compiler to make optimizations and avoid undefined behavior when things go out of scope.

Originally posted by @eflumerf in #245 (comment)

[rrivera747]

Would need something like this std::optional<std::string&> which is not allowed.

[rrivera747]

Likely shared_ptr is best solution, but maybe low priority to implement compared to the cascade of changes it would cause.