Allow hiera merging of sudo::sudoers

[christianbrensing]

If sudo::sudoers is defined via Hiera only the configuration from one hierarchy will be preserved.

Given the following hiera hierachy:

:hierarchy:
  - "%{::clientcert}"
  - "defaults"

If you define sudo::sudoers both in e.g. bar.foo.org.yaml and in defaults.yaml with different rules, only the rules hash from defaults.yaml will be autowired to the param sudoers of the sudo class, losing the rules defined in bar.foo.org.yaml.

Other module like https://github.com/saz/puppet-sudo are using hiera_hash() to merge all hashes.

Perhaps you could add a parameter hiera_merge_sudoers like the one in the nrpe module by ghoneycutt (https://github.com/ghoneycutt/puppet-module-nrpe), defaulting to false, to read and merge the hashes from Hiera.

Example implementation

if $hiera_merge_sudoers {
  $sudoers_real = hiera_hash(sudo::sudoers)
} else {
   $sudoers_real = $sudoers
}
create_resources('sudo::sudoers', $sudoers_real)

I could provide a pull request if you like.

[issmarckri]

Hi,

did you ever provide that pull request?

Thanks
Kristian

[christianbrensing]

Hi Kristian,
unfortunately no. No one asked me to.
Regards,
Christian

[issmarckri]

Hi Christian,

well I think it would still be beneficial if you did.

Thanks
Kristian

[bschonec]

Add this to your common.yaml file:

lookup_options:
  sudo::sudoers:
    merge: deep

or use a create_resources call:

create_resources(sudo::sudoers, lookup('sudo::sudoers', Optional[Hash], {strategy => 'deep'}, {}))