Request timeout is not honored

[mickyhale]

I was attempting to adjust request timeout to 40 which I believed would affect all call methods in CvpApi, but it wasn't working for get_configlets_and_mappers().

Debug snippet from my app:

...
[cvprac] get_configlets_and_mappers: getConfigletsAndAssociatedMappers
[cvprac] HTTPSConnectionPool(host='some.host', port=443): Read timed out. (read timeout=30)
...

I took a look at the code and saw that timeout wasn't set for that call. That would be a simple enough fix but then I looked at how request_timeout is being passed and it seems like it should be an attribute set in CvpClient (instead of CvpApi). It could happen either in the connect call where connect_timeout is set or during instantiation (exposing both timeouts to the user prior to connect might be nice).

I was going to submit a pull request with the proposed change, but thought I might bring it up first in case I'm missing the reasoning behind how it's configured and because the change that I'm suggesting isn't entirely trivial.

Thank you for the library.

[mharista]

Thanks @mickyhale

I'll take a look at this and try to get it addressed before the next release.

[perimore]

Can someone look at this more generally please? There are a number of queries that do not pass in the timeout value. E.g.:

cvprac/cvprac/cvp_api.py

Line 1060 in 2a46728

return self.clnt.get(f"/inventory/add/searchContainers.do?"

cvprac/cvprac/cvp_api.py

Line 1063 in 2a46728

containers = self.clnt.get('/inventory/containers')

All queries in get_container_by_name:

cvprac/cvprac/cvp_api.py

Line 1090 in 2a46728

def get_container_by_name(self, name):

Thanks

[mharista]

These have been addressed here #302 by @rwlaws .