Simple fix for bad background color on last prompt character.#138
Open
tauchris wants to merge 1 commit intoarialdomartini:masterfrom
Open
Simple fix for bad background color on last prompt character.#138tauchris wants to merge 1 commit intoarialdomartini:masterfrom
tauchris wants to merge 1 commit intoarialdomartini:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fear this repo has been abandoned... and it looks like this issue has been addressed in some previous pull requests (which have not been accepted or closed). But the fix seems simple to me, so I'll risk my time by offering it again...
My fix just involves doing a full reset, and then setting only the foreground color before emitting the last character. I haven't run across any terminal emulators (in any color-enabled modes) where this doesn't work. If I've missed some case(s) where this won't work, please share the specifics.