Skip to content

No color sass maps #2

@inorganik

Description

@inorganik

I love this project! I think it's really well executed.

I see you've supplemented the color sass maps material ships for its default colors by using lighten() and darken() to fill in the holes in the foreground and background variables. This seems to work fine. But do you think this could be a brittle solution? I don't know if it's a good idea to overwrite the foreground and background variables, I'll explain why.

For instance, if Material ships a new component, that will add a new key to those variables which would not exist in your override until you updated this tool. Could you instead use lighten and darken to generate the sass-map of colors and use that, eliminating the need to override foreground and background vars? Something to think about.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions