From 2503cec15ca1831917a57421bc2144fd50f9d4de Mon Sep 17 00:00:00 2001 From: Julian Popescu Date: Sat, 10 Jan 2026 01:13:28 +0100 Subject: [PATCH] ci: require release for docker image so that python version is available --- .github/workflows/cd.yaml | 7 +++---- src/commands/new/dataset_marimo.rs | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/cd.yaml b/.github/workflows/cd.yaml index 90d69db..7f05476 100644 --- a/.github/workflows/cd.yaml +++ b/.github/workflows/cd.yaml @@ -107,7 +107,6 @@ jobs: release: name: Release runs-on: ubuntu-latest - if: "startsWith(github.ref, 'refs/tags/')" needs: [linux, windows, macos, sdist] steps: - uses: actions/download-artifact@v4 @@ -116,6 +115,7 @@ jobs: merge-multiple: true - name: Publish to PyPI uses: PyO3/maturin-action@v1 + if: "startsWith(github.ref, 'refs/tags/')" env: MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_API_TOKEN }} with: @@ -125,6 +125,7 @@ jobs: docker: name: Build and Push Docker Image runs-on: ubuntu-latest + needs: [release] permissions: contents: read packages: write @@ -159,9 +160,7 @@ jobs: files: | ./docker-bake.hcl cwd://${{ steps.meta-kubimo.outputs.bake-file }} - # TODO: change before merging - # push: ${{ github.event_name != 'pull_request' }} - push: true + push: ${{ github.event_name != 'pull_request' }} npm: name: Build and publish npm package diff --git a/src/commands/new/dataset_marimo.rs b/src/commands/new/dataset_marimo.rs index 8055e27..e4f4e17 100644 --- a/src/commands/new/dataset_marimo.rs +++ b/src/commands/new/dataset_marimo.rs @@ -119,7 +119,7 @@ pub async fn dataset_marimo(args: DatasetMarimo, global: GlobalArgs) -> Result<( .map_err(|e| format_permission_error("create dataset-marimo", &dest, &e))?; pb.finish_with_message(format!( - "Created dataset marimo noteboook in '{}'", + "Created dataset marimo notebook in '{}'", dest.display() )); Ok(())