Skip to content

Refactor config #85

@laggingreflex

Description

@laggingreflex

I think config should be refactored. It'll probably be required to be done in #78, so here's a couple ideas that could be helpful to implement while refactoring

  • combine project config and CLI args.

    The two options I added in feat: disable triggerBigSync #84 (disableDeletion & disableRsync) can be configured by both project config as well as CLI args but it looks ugly if (!(params.disableDeletion || project.disableDeletion)) {. They should be combined before this check.

  • CLI params should override project config.

  • There should a default master config that should be applied for all projects. Currently all projects have their own separate configs and there's a lot of duplication in config itself that way. A master config could help a lot. The project config could then only be used to override the default one. (and CLI params still override them both)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions