diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 07ccb8922b3..aebefaf1331 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -136,6 +136,12 @@ repos: - id: black-jupyter name: run black-jupyter description: format Python files and Jupyter Notebooks with black + - repo: https://github.com/jendrikseipp/vulture + rev: v2.14 + hooks: + - id: vulture + name: run vulture + description: find dead Python code - repo: https://github.com/pre-commit/mirrors-clang-format rev: v20.1.0 hooks: diff --git a/pyproject.toml b/pyproject.toml index ddee9cf63df..b374308a736 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -21,3 +21,8 @@ skips = ["B101", "B403", "B405", "B608"] [tool.codespell] ignore-words = '.github/linters/codespell.txt' skip = './docs/image,./docs/usecases,./site,./spark/common/src/test/resources,./tools/maven/scalafmt.conf' + +[tool.vulture] +min_confidence = 100 +paths = ["docs/usecases/utilities.py", "python/", "spark-version-converter.py"] +sort_by_size = true diff --git a/python/sedona/maps/SedonaPyDeck.py b/python/sedona/maps/SedonaPyDeck.py index a553817ec8f..c6c103ef1cd 100644 --- a/python/sedona/maps/SedonaPyDeck.py +++ b/python/sedona/maps/SedonaPyDeck.py @@ -318,7 +318,7 @@ def _create_default_fill_color_(cls, gdf, plot_col): return f"[85, 183, 177, ({plot_col} / {plot_max}) * 255 + 15]" @classmethod - def _create_coord_column_(cls, gdf, geometry_col, add_points=False): + def _create_coord_column_(cls, gdf, geometry_col): """ Create a coordinate column in a given GeoPandas Dataframe, this coordinate column contains coordinates of a ST_Point in a list format of [longitude, latitude] :param gdf: GeoPandas Dataframe diff --git a/python/sedona/raster/sedona_raster.py b/python/sedona/raster/sedona_raster.py index ccb90de001a..082b171648b 100644 --- a/python/sedona/raster/sedona_raster.py +++ b/python/sedona/raster/sedona_raster.py @@ -215,7 +215,7 @@ def close(self): def __enter__(self): return self - def __exit__(self, exc_type, exc_val, exc_tb): + def __exit__(self, exc_type, exc_val, exc_tb): # noqa self.close() def __del__(self): diff --git a/python/sedona/utils/abstract_parser.py b/python/sedona/utils/abstract_parser.py index fdf3a067c5b..e746576056f 100644 --- a/python/sedona/utils/abstract_parser.py +++ b/python/sedona/utils/abstract_parser.py @@ -29,7 +29,7 @@ def name(self): raise NotImplementedError @classmethod - def serialize(cls, obj: BaseGeometry, binary_buffer: "BinaryBuffer"): + def serialize(cls, obj: BaseGeometry): raise NotImplementedError("Parser has to implement serialize method") @classmethod diff --git a/python/sedona/utils/spatial_rdd_parser.py b/python/sedona/utils/spatial_rdd_parser.py index d99eecf8075..158eb42b679 100644 --- a/python/sedona/utils/spatial_rdd_parser.py +++ b/python/sedona/utils/spatial_rdd_parser.py @@ -102,7 +102,7 @@ def __ne__(self, other): class AbstractSpatialRDDParser(ABC): @classmethod - def serialize(cls, obj: List[Any], binary_buffer: "BinaryBuffer") -> bytearray: + def serialize(cls, obj: List[Any]) -> bytearray: raise NotImplemented() @classmethod @@ -132,7 +132,7 @@ def deserialize(cls, bin_parser: "BinaryParser"): return deserialized_data @classmethod - def serialize(cls, obj: BaseGeometry, binary_buffer: "BinaryBuffer"): + def serialize(cls, obj: BaseGeometry): raise NotImplementedError("Currently this operation is not supported") @@ -148,7 +148,7 @@ def deserialize(cls, bin_parser: "BinaryParser"): return left_geom_data @classmethod - def serialize(cls, obj: BaseGeometry, binary_buffer: "BinaryBuffer"): + def serialize(cls, obj: BaseGeometry): raise NotImplementedError("Currently this operation is not supported") @@ -175,7 +175,7 @@ def deserialize(cls, bin_parser: "BinaryParser"): return deserialized_data @classmethod - def serialize(cls, obj: BaseGeometry, binary_buffer: "BinaryBuffer"): + def serialize(cls, obj: BaseGeometry): raise NotImplementedError("Currently this operation is not supported") diff --git a/python/tests/spatial_rdd/test_spatial_rdd_writer.py b/python/tests/spatial_rdd/test_spatial_rdd_writer.py index 2e5a571c369..68e4d7af490 100644 --- a/python/tests/spatial_rdd/test_spatial_rdd_writer.py +++ b/python/tests/spatial_rdd/test_spatial_rdd_writer.py @@ -74,7 +74,7 @@ def remove_wkb_directory(): class TestSpatialRDDWriter(TestBase): - def test_save_as_geo_json_with_data(self, remove_wkb_directory): + def test_save_as_geo_json_with_data(self): spatial_rdd = PointRDD( sparkContext=self.sc, InputLocation=inputLocation,