Skip to content

chore: Find and replace DataFusionError::Internal #376

@petern48

Description

@petern48

See this PR for context. Looks like there's DataFusionError::Internal somewhere in the parse code. This can make it confusing for contributors when they write improper geometries in their tests.

FAILED sedonadb/tests/functions/test_functions.py::test_st_numinteriorrings_basic[POLYGON (                (0 0,10 0,10 6,0 6,0 0)                (1 1,2 1,2 5,1 5,1 1),                (8 5,8 4,9 4,9 5,8 5))-2-SedonaDB] - pyarrow.lib.ArrowInvalid: External error: Internal error: WKT parse error: Missing closing parenthesis for type.
This issue was likely caused by a bug in DataFusion's code. Please help us to resolve this by filing a bug report in our issue tracker: https://github.com/apache/datafusion/issues

ci run

I now remember, that the PR that introduced sedona_internal_err replaced all of the internal_err calls at the time, but didn't touch any of the DataFusionError::Internal

There are still plenty of more uses of these throughout the codebase: https://github.com/search?q=repo%3Aapache%2Fsedona-db+%22DataFusionError%3A%3AInternal%22&type=code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions