[Bug] Invalid parameter type passed to Map.get

[lhotari]

Search before reporting

• I searched in the issues and found nothing similar.

Read release policy

• I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

User environment

master branch

Issue Description

error-prone detected issue

error: [CollectionIncompatibleType] Argument 'QueryParam.Bundle.value' should not be passed to this method; its type String is not compatible with its collection's type argument QueryParam

in this code:

pulsar/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java

Lines 182 to 190 in b3c5148

	@Override
	public CompletableFuture<List<String>> getListAsync(String namespace, TopicDomain topicDomain,
	Map<QueryParam, Object> params) {
	ListTopicsOptions options = ListTopicsOptions
	.builder()
	.bundle((String) params.get(QueryParam.Bundle.value))
	.build();
	return getListAsync(namespace, topicDomain, options);
	}

According to the type parameters, it should be QueryParam.Bundle instead of QueryParam.Bundle.value. It's unclear why tests didn't catch this issue.

Error messages

Reproducing the issue

See description.

Additional information

No response

Are you willing to submit a PR?

• I'm willing to submit a PR!

[oneby-wang]

Is there any test to cover this method? Seems like this method is deprecated and has no reference anywhere.

[lhotari]

Is there any test to cover this method? Seems like this method is deprecated and has no reference anywhere.

@oneby-wang I guess we should just remove the method if there's no reference since it's broken in any case. An alternative would be to replace QueryParam.Bundle.value with QueryParam.Bundle.

[oneby-wang]

@lhotari I would like to help check and fix this.