-
Notifications
You must be signed in to change notification settings - Fork 293
[MNGSITE-515] Update introduction to profiles #1490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
content/markdown/guides/introduction/introduction-to-profiles.md
Outdated
Show resolved
Hide resolved
content/markdown/guides/introduction/introduction-to-profiles.md
Outdated
Show resolved
Hide resolved
content/markdown/guides/introduction/introduction-to-profiles.md
Outdated
Show resolved
Hide resolved
content/markdown/guides/introduction/introduction-to-profiles.md
Outdated
Show resolved
Hide resolved
content/markdown/guides/introduction/introduction-to-profiles.md
Outdated
Show resolved
Hide resolved
| Since [Maven 3.9.7](https://issues.apache.org/jira/browse/MNG-5726) the value for `version` may be prefixed with `regex:`. In that case [regular pattern matching](https://docs.oracle.com/javase/tutorial/essential/regex/) is applied for the version matching and applied against the **lower case** `os.version` value. | ||
|
|
||
| The actual OS values which need to match the given values are emitted when executing `mvn --version`. | ||
| See the maven-enforcer-plugin's [Require OS Rule](/enforcer/enforcer-rules/requireOS.html) for more details about OS values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be better as an absolute URL in case this site is mirrored somewhere
content/markdown/guides/introduction/introduction-to-profiles.md
Outdated
Show resolved
Hide resolved
|
@elharo PTAL :) |
|
|
||
| [Ranges](/enforcer/enforcer-rules/versionRanges.html) can also be used. Range values must start with either `[` or `(`. Otherwise, the value is interpreted as a prefix. The following honours versions `1.3`, `1.4` and `1.5`. | ||
| [Ranges](/enforcer/enforcer-rules/versionRanges.html) can also be used. Range values must start with either `[` or `(`. | ||
| The following honours versions `1.3`, `1.4` and `1.5`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oxford comma after 1.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
This PR removes almost the entire examples about
<profiles>of the POM reference and integrates them into the profile guide to avoid duplication and inconsistent content.Some missing or unclear parts were also added to the guide (as requested in the issue).
closes #873