From c58f61199d90857b10e0eb18f8659d099f792b08 Mon Sep 17 00:00:00 2001 From: Hongze Zhang Date: Thu, 5 Mar 2026 16:20:12 +0100 Subject: [PATCH] [VL] Add metric preloadSplitPrepareTimeNanos --- cpp/velox/compute/WholeStageResultIterator.cc | 4 +++- dev/check.py | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/cpp/velox/compute/WholeStageResultIterator.cc b/cpp/velox/compute/WholeStageResultIterator.cc index babcaf0e5f64..6389c1e0eff6 100644 --- a/cpp/velox/compute/WholeStageResultIterator.cc +++ b/cpp/velox/compute/WholeStageResultIterator.cc @@ -60,6 +60,7 @@ const std::string kPreloadSplits = "readyPreloadedSplits"; const std::string kPageLoadTime = "pageLoadTimeNs"; const std::string kDataSourceAddSplitWallNanos = "dataSourceAddSplitWallNanos"; const std::string kWaitForPreloadSplitNanos = "waitForPreloadSplitNanos"; +const std::string kPreloadSplitPrepareTimeNanos = "preloadSplitPrepareTimeNanos"; const std::string kDataSourceReadWallNanos = "dataSourceReadWallNanos"; const std::string kNumWrittenFiles = "numWrittenFiles"; const std::string kWriteIOTime = "writeIOWallNanos"; @@ -514,7 +515,8 @@ void WholeStageResultIterator::collectMetrics() { metrics_->get(Metrics::kPageLoadTime)[metricIndex] = runtimeMetric("sum", second->customStats, kPageLoadTime); metrics_->get(Metrics::kDataSourceAddSplitWallNanos)[metricIndex] = runtimeMetric("sum", second->customStats, kDataSourceAddSplitWallNanos) + - runtimeMetric("sum", second->customStats, kWaitForPreloadSplitNanos); + runtimeMetric("sum", second->customStats, kWaitForPreloadSplitNanos) + + runtimeMetric("sum", second->customStats, kPreloadSplitPrepareTimeNanos); metrics_->get(Metrics::kDataSourceReadWallNanos)[metricIndex] = runtimeMetric("sum", second->customStats, kDataSourceReadWallNanos); metrics_->get(Metrics::kNumWrittenFiles)[metricIndex] = diff --git a/dev/check.py b/dev/check.py index f1ec051c90d5..8d8f666e27ab 100755 --- a/dev/check.py +++ b/dev/check.py @@ -24,7 +24,7 @@ from util import attrdict import util -EXTENSIONS = "cpp,h,inc,prolog" +EXTENSIONS = "cc,cpp,h,inc,prolog" SCRIPTS = util.script_path()