From 3b26abc9d5b81998ff52d66ee88f296db03bebb7 Mon Sep 17 00:00:00 2001 From: Yuan Date: Tue, 3 Mar 2026 17:45:37 +0000 Subject: [PATCH 1/8] [VL] Trigger docker build if script changes Signed-off-by: Yuan --- .github/workflows/nightly_sync.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/.github/workflows/nightly_sync.yml b/.github/workflows/nightly_sync.yml index 445b2dfccf7f..a1a49b24554c 100644 --- a/.github/workflows/nightly_sync.yml +++ b/.github/workflows/nightly_sync.yml @@ -21,6 +21,25 @@ on: - 'docs/**' - '.github/workflows/nightly_sync.yml' jobs: + + gpu-docker-tests: + name: check Velox script change + runs-on: ubuntu-latest + steps: + - name: Check if scripts changed + run: | + if [[ $(git diff --name-only ${{ github.event.before }} ${{ github.event.after }} | grep -E '(^|/)scripts/.*') ]]; then + echo "Scripts changed, run gpu-docker-tests" + exit 1 + else + echo "No script changes, skip gpu-docker-tests" + fi + + - name: Run Docker Image build + uses: apache/gluten/.github/workflows/docker_image.yml@master + with: + image_tag: ${{ inputs.RELEASE_VERSION }} + upload_to_nightlies: if: ${{ startsWith(github.repository, 'apache/') }} runs-on: ubuntu-latest From e8eee5b81c0a9db4a886ff15397471ae6e825e2a Mon Sep 17 00:00:00 2001 From: Yuan Date: Tue, 3 Mar 2026 17:50:34 +0000 Subject: [PATCH 2/8] test Signed-off-by: Yuan --- .github/workflows/nightly_sync.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nightly_sync.yml b/.github/workflows/nightly_sync.yml index a1a49b24554c..15aba6a21eb9 100644 --- a/.github/workflows/nightly_sync.yml +++ b/.github/workflows/nightly_sync.yml @@ -16,14 +16,14 @@ name: Upload docs to apache nightly on: - push: + pull_request: paths: - 'docs/**' - '.github/workflows/nightly_sync.yml' jobs: gpu-docker-tests: - name: check Velox script change + name: check Velox script change and build docker image if changed runs-on: ubuntu-latest steps: - name: Check if scripts changed From 19839eacf43e1c18986793066254052310ea80e8 Mon Sep 17 00:00:00 2001 From: Yuan Date: Tue, 3 Mar 2026 17:53:10 +0000 Subject: [PATCH 3/8] fix logic Signed-off-by: Yuan --- .github/workflows/nightly_sync.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nightly_sync.yml b/.github/workflows/nightly_sync.yml index 15aba6a21eb9..8419b8a38716 100644 --- a/.github/workflows/nightly_sync.yml +++ b/.github/workflows/nightly_sync.yml @@ -22,8 +22,8 @@ on: - '.github/workflows/nightly_sync.yml' jobs: - gpu-docker-tests: - name: check Velox script change and build docker image if changed + script-change-test: + name: check Velox script change runs-on: ubuntu-latest steps: - name: Check if scripts changed @@ -34,7 +34,12 @@ jobs: else echo "No script changes, skip gpu-docker-tests" fi - + + gpu-docker-tests: + needs: script-change-test + name: check Velox script change and build docker image if changed + runs-on: ubuntu-latest + steps: - name: Run Docker Image build uses: apache/gluten/.github/workflows/docker_image.yml@master with: From 0377e61004c45dabdfe6a2c78acebe2be69430d3 Mon Sep 17 00:00:00 2001 From: Yuan Date: Tue, 3 Mar 2026 17:55:57 +0000 Subject: [PATCH 4/8] fix Signed-off-by: Yuan --- .github/workflows/nightly_sync.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/nightly_sync.yml b/.github/workflows/nightly_sync.yml index 8419b8a38716..fac8fc5aa8e4 100644 --- a/.github/workflows/nightly_sync.yml +++ b/.github/workflows/nightly_sync.yml @@ -37,13 +37,8 @@ jobs: gpu-docker-tests: needs: script-change-test - name: check Velox script change and build docker image if changed - runs-on: ubuntu-latest - steps: - - name: Run Docker Image build - uses: apache/gluten/.github/workflows/docker_image.yml@master - with: - image_tag: ${{ inputs.RELEASE_VERSION }} + checkout: + uses: ./.github/workflows/docker_image.yml@master upload_to_nightlies: if: ${{ startsWith(github.repository, 'apache/') }} From 3fb25d03140aae6bab1f2beb7ccf31f7fd241678 Mon Sep 17 00:00:00 2001 From: Yuan Date: Tue, 3 Mar 2026 18:15:35 +0000 Subject: [PATCH 5/8] fix Signed-off-by: Yuan --- .github/workflows/nightly_sync.yml | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/.github/workflows/nightly_sync.yml b/.github/workflows/nightly_sync.yml index fac8fc5aa8e4..75654ea4b70a 100644 --- a/.github/workflows/nightly_sync.yml +++ b/.github/workflows/nightly_sync.yml @@ -23,22 +23,31 @@ on: jobs: script-change-test: - name: check Velox script change + name: check Velox script change and build docker image if needed runs-on: ubuntu-latest steps: - name: Check if scripts changed run: | + git clone --depth 10 --branch master https://github.com/facebookincubator/velox.git velox + cd velox if [[ $(git diff --name-only ${{ github.event.before }} ${{ github.event.after }} | grep -E '(^|/)scripts/.*') ]]; then echo "Scripts changed, run gpu-docker-tests" exit 1 else echo "No script changes, skip gpu-docker-tests" fi - - gpu-docker-tests: - needs: script-change-test - checkout: - uses: ./.github/workflows/docker_image.yml@master + - name: Set up Git + run: | + git config user.name "github-actions[bot]" + git config user.email "github-actions[bot]@users.noreply.github.com" + + - name: Check CI Status + # Allow manual triggered workflows to circumvent the check + if: ${{ github.event_name != 'workflow_dispatch' }} + env: + GH_TOKEN: ${{ github.token }} + run: | + gh workflow run ./.github/workflows/docker_image.yml -f job_to_run=build-centos-9-jdk8-cudf upload_to_nightlies: if: ${{ startsWith(github.repository, 'apache/') }} From 8509b8af4753b20ce6a87395ded5db37091a16e5 Mon Sep 17 00:00:00 2001 From: Yuan Date: Tue, 3 Mar 2026 18:16:21 +0000 Subject: [PATCH 6/8] fix Signed-off-by: Yuan --- .github/workflows/nightly_sync.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly_sync.yml b/.github/workflows/nightly_sync.yml index 75654ea4b70a..54e8f2618462 100644 --- a/.github/workflows/nightly_sync.yml +++ b/.github/workflows/nightly_sync.yml @@ -28,7 +28,7 @@ jobs: steps: - name: Check if scripts changed run: | - git clone --depth 10 --branch master https://github.com/facebookincubator/velox.git velox + git clone --depth 10 --branch main https://github.com/facebookincubator/velox.git velox cd velox if [[ $(git diff --name-only ${{ github.event.before }} ${{ github.event.after }} | grep -E '(^|/)scripts/.*') ]]; then echo "Scripts changed, run gpu-docker-tests" From 31ef335f22c824d7675b50f4f6f4283685ec826d Mon Sep 17 00:00:00 2001 From: Yuan Date: Tue, 3 Mar 2026 18:18:03 +0000 Subject: [PATCH 7/8] fix Signed-off-by: Yuan --- .github/workflows/nightly_sync.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly_sync.yml b/.github/workflows/nightly_sync.yml index 54e8f2618462..8120eb9bcd6c 100644 --- a/.github/workflows/nightly_sync.yml +++ b/.github/workflows/nightly_sync.yml @@ -32,9 +32,9 @@ jobs: cd velox if [[ $(git diff --name-only ${{ github.event.before }} ${{ github.event.after }} | grep -E '(^|/)scripts/.*') ]]; then echo "Scripts changed, run gpu-docker-tests" - exit 1 else echo "No script changes, skip gpu-docker-tests" + exit 0 fi - name: Set up Git run: | From 6801a017ac3e92ec9f0f7d988ef84bf992ca401a Mon Sep 17 00:00:00 2001 From: Yuan Date: Tue, 3 Mar 2026 18:21:59 +0000 Subject: [PATCH 8/8] fix Signed-off-by: Yuan --- .github/workflows/nightly_sync.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nightly_sync.yml b/.github/workflows/nightly_sync.yml index 8120eb9bcd6c..08a6e47ceca1 100644 --- a/.github/workflows/nightly_sync.yml +++ b/.github/workflows/nightly_sync.yml @@ -25,25 +25,30 @@ jobs: script-change-test: name: check Velox script change and build docker image if needed runs-on: ubuntu-latest + outputs: + scripts_changed: ${{ steps.check_scripts.outputs.scripts_changed }} steps: - name: Check if scripts changed + id: check_scripts run: | git clone --depth 10 --branch main https://github.com/facebookincubator/velox.git velox cd velox if [[ $(git diff --name-only ${{ github.event.before }} ${{ github.event.after }} | grep -E '(^|/)scripts/.*') ]]; then echo "Scripts changed, run gpu-docker-tests" + echo "::set-output name=scripts_changed::true" else echo "No script changes, skip gpu-docker-tests" + echo "::set-output name=scripts_changed::false" exit 0 fi - name: Set up Git + if: steps.check_scripts.outputs.scripts_changed == 'true' run: | git config user.name "github-actions[bot]" git config user.email "github-actions[bot]@users.noreply.github.com" - name: Check CI Status - # Allow manual triggered workflows to circumvent the check - if: ${{ github.event_name != 'workflow_dispatch' }} + if: steps.check_scripts.outputs.scripts_changed == 'true' env: GH_TOKEN: ${{ github.token }} run: |