From 05fda48292dc511ba497f7535ee3bd694096d57b Mon Sep 17 00:00:00 2001 From: Ankita Victor-Levi Date: Mon, 16 Feb 2026 11:45:46 +0530 Subject: [PATCH] Fix throw-new anti-pattern in FileReaderIterator.cc Throw exceptions by value, not by pointer. Using throw new heap-allocates the exception object which will never be freed since catch blocks expect to catch by reference, causing a memory leak on the exception path. --- cpp/velox/operators/reader/FileReaderIterator.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/velox/operators/reader/FileReaderIterator.cc b/cpp/velox/operators/reader/FileReaderIterator.cc index 9e14a760c47c..9528763fbc77 100644 --- a/cpp/velox/operators/reader/FileReaderIterator.cc +++ b/cpp/velox/operators/reader/FileReaderIterator.cc @@ -41,7 +41,7 @@ std::shared_ptr FileReaderIterator::getInputIteratorFrom std::make_unique(path, batchSize, pool)); } } - throw new GlutenException("Unreachable."); + throw GlutenException("Unreachable."); } } // namespace gluten