[GLUTEN-7548][VL] Follow up hash join optimization PR 8931 to resolve comments#11728
Merged
JkSelf merged 2 commits intoapache:mainfrom Mar 10, 2026
Merged
[GLUTEN-7548][VL] Follow up hash join optimization PR 8931 to resolve comments#11728JkSelf merged 2 commits intoapache:mainfrom
JkSelf merged 2 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
@jinchengchenghh @liujiayi771 @zhztheplayer Could you help to review this PR? Thanks. |
zhztheplayer
approved these changes
Mar 9, 2026
Member
zhztheplayer
left a comment
zhztheplayer
left a comment
There was a problem hiding this comment.
I am also curious where hash table copies happen in the design? Thanks. #8931 (comment)
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
@zhztheplayer @jinchengchenghh @liujiayi771 Do you have any further comments? Thanks. |
jinchengchenghh
approved these changes
Mar 10, 2026
zhztheplayer
approved these changes
Mar 10, 2026
jinchengchenghh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Follow up 8931 to resolve comments
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
No
Related issue: #7548