[GLUTEN-11635] Enable partial fallback if parent node supports partial fallback#11637
Merged
jinchengchenghh merged 4 commits intoapache:mainfrom Mar 10, 2026
Merged
Conversation
747d9fc to
8b4e841
Compare
Contributor
Author
|
@jinchengchenghh @weixiuli Could you pls take a look? Thanks~ |
backends-velox/src/main/scala/org/apache/gluten/extension/PartialProjectRule.scala
Outdated
Show resolved
Hide resolved
Member
|
Is there always a benefit to this? It does a partial projection, but with an extra C2R/R2C conversion.
|
Contributor
|
Could you show the number that this PR can gain improvement? |
8b4e841 to
413cb80
Compare
Contributor
Author
|
I have run a simple test that read and write table, it shows little improvements, I think we could benefit a lot more if the operations offloaded to native are more complicated. cc: @jinchengchenghh @wForget insert overwrite table dev_spark_auxiliary.wechar_tbl2
select plus_one(col1) as col2, col3 from (
select col1, log_type as col3
from test_db.test_tbl
lateral view simpleUDTF(item_id) as col1
where grass_region='BR' and regional_date='2026-03-01'
)
|
jinchengchenghh
approved these changes
Mar 6, 2026
| case other => other | ||
| } | ||
| } | ||
| newPlan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are proposed in this pull request?
Fix #11635
How was this patch tested?
Add a new unit test.
Before this PR:
After this PR:
VeloxColumnarToRow +- ^(3) ProjectExecTransformer [_SparkPartialProject0#56L AS col2#38L, l_partkey#1L] +- ^(3) InputIteratorTransformer[col1#37L, l_partkey#1L, _SparkPartialProject0#56L] +- ColumnarPartialProject [if (isnull(col1#37L)) null else plus_one(knownnotnull(col1#37L)) AS col2#38L, l_partkey#1L] PartialProject List(if (isnull(col1#37L)) null else plus_one(knownnotnull(col1#37L)) AS _SparkPartialProject0#56L) +- ^(2) ProjectExecTransformer [_SparkPartialProject0#55L AS col1#37L, l_partkey#1L] +- ^(2) InputIteratorTransformer[l_orderkey#0L, l_partkey#1L, _SparkPartialProject0#55L] +- ColumnarPartialProject [if (isnull(l_orderkey#0L)) null else plus_one(knownnotnull(l_orderkey#0L)) AS col1#37L, l_partkey#1L] PartialProject List(if (isnull(l_orderkey#0L)) null else plus_one(knownnotnull(l_orderkey#0L)) AS _SparkPartialProject0#55L) +- ^(1) BatchScanExecTransformer parquet file:/root/workspace/gluten-community/backends-velox/target/scala-2.13/test-classes/tpch-data-parquet/lineitem[l_orderkey#0L, l_partkey#1L] ParquetScan DataFilters: [], Format: parquet, Location: InMemoryFileIndex(1 paths)[file:/root/workspace/gluten-community/backends-velox/target/scala-2.13..., PartitionFilters: [], PushedAggregation: [], PushedFilters: [], PushedGroupBy: [], ReadSchema: struct<l_orderkey:bigint,l_partkey:bigint> RuntimeFilters: [] NativeFilters: []Was this patch authored or co-authored using generative AI tooling?
No.