[VL] Allocate VarChar sub-messages on protobuf arena in VeloxToSubstraitExpr#11636
Merged
rui-mo merged 2 commits intoapache:mainfrom Mar 9, 2026
Merged
[VL] Allocate VarChar sub-messages on protobuf arena in VeloxToSubstraitExpr#11636rui-mo merged 2 commits intoapache:mainfrom
rui-mo merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@rui-mo can you please review this PR? Thanks in advance! |
rui-mo
approved these changes
Mar 2, 2026
Contributor
Author
|
@rui-mo thanks for the review and approvals! Please let me know if there’s anything else needed from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR replaces
newallocation ofVarCharsub-messages withArena::CreateMessageto match the arena-allocated parent inVeloxToSubstraitExpr.cc. When a protobuf message is arena-allocated, its destructor never runs so children attached viaset_allocated_*that were heap-allocated withneware never deleted. Every other sub-message in this file already usesArena::CreateMessagecorrectly andVarCharwas the only exception.How was this patch tested?
Existing UTs
Was this patch authored or co-authored using generative AI tooling?
No