You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Upstream Velox doesn't have CI to track Gluten, so any Velox PR may break Gluten's functionality.
So now we use oap/velox to build Gluten. Once an upstream PR break Gluten's build or CI, we revert it in oap/velox and submit followup PRs to upstream to fix. If it only break some UT, we sometimes just disable the UT which is listed here: #10140
Currently the workflow is that Velox has a hook which can notify us on each PR update, once a PR is merged we will rebase the PR in ibm/velox and trigger CI for it. The IBM team @zhouyuan@rui-mo@marin-ma@zhztheplayer@jinchengchenghh@FelixYBW maintain the ibm/velox daily to make sure upstream velox is rebased into ibm/velox then we push into oap/velox.
While OAP/velox is a third party repo not maintained by any Gluten committers later. It's used for history reason. All the work is done in ibm/velox today. So we submitted PR #11086 to replace oap/velox by ibm/velox.
We are actively working to push gluten essential PRs to upstream (it's already 1 year but little progress). Once it's done we will seek better solution.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
It's a known issue that upstream velox can't be used by Gluten for two reasons:
So now we use oap/velox to build Gluten. Once an upstream PR break Gluten's build or CI, we revert it in oap/velox and submit followup PRs to upstream to fix. If it only break some UT, we sometimes just disable the UT which is listed here: #10140
Currently the workflow is that Velox has a hook which can notify us on each PR update, once a PR is merged we will rebase the PR in ibm/velox and trigger CI for it. The IBM team @zhouyuan @rui-mo @marin-ma @zhztheplayer @jinchengchenghh @FelixYBW maintain the ibm/velox daily to make sure upstream velox is rebased into ibm/velox then we push into oap/velox.
While OAP/velox is a third party repo not maintained by any Gluten committers later. It's used for history reason. All the work is done in ibm/velox today. So we submitted PR #11086 to replace oap/velox by ibm/velox.
We are actively working to push gluten essential PRs to upstream (it's already 1 year but little progress). Once it's done we will seek better solution.
Beta Was this translation helpful? Give feedback.
All reactions