From 1943e860d2c641d09ae09ed07354c5906e95d786 Mon Sep 17 00:00:00 2001 From: Abderrahim Kitouni Date: Sat, 24 May 2025 08:39:56 +0100 Subject: [PATCH] cascache: fix pushing with remote cache CASCache.send_blobs() expects to be able to iterate twice on the passed digests (though it only does so when using a remote cache). Make sure to pass a list rather than a generator. --- src/buildstream/_cas/cascache.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/buildstream/_cas/cascache.py b/src/buildstream/_cas/cascache.py index 6a4043f73..fbfc150f3 100644 --- a/src/buildstream/_cas/cascache.py +++ b/src/buildstream/_cas/cascache.py @@ -702,7 +702,7 @@ def send_blobs(self, remote, digests): batch.send() def _send_directory(self, remote, digest): - required_blobs = self.required_blobs_for_directory(digest) + required_blobs = list(self.required_blobs_for_directory(digest)) # Upload any blobs missing on the server. # buildbox-casd will call FindMissingBlobs before the actual upload