From 27a5fca9cca6209e8a6fc81272d8afc655175b23 Mon Sep 17 00:00:00 2001 From: Andrew Crites Date: Mon, 23 Feb 2026 14:56:34 -0800 Subject: [PATCH] Moves expectMessage to before creating BeamFnLoggingClient since exception can be thrown inside createAndStart method. --- .../apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java b/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java index 0ba56047d0c3..2dd2b2bad53f 100644 --- a/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java +++ b/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java @@ -532,6 +532,7 @@ public StreamObserver logging( ManagedChannel channel = InProcessChannelBuilder.forName(apiServiceDescriptor.getUrl()).build(); try { + thrown.expectMessage("Logging stream terminated unexpectedly"); BeamFnLoggingClient client = BeamFnLoggingClient.createAndStart( PipelineOptionsFactory.fromArgs( @@ -543,7 +544,6 @@ public StreamObserver logging( apiServiceDescriptor, (Endpoints.ApiServiceDescriptor descriptor) -> channel); - thrown.expectMessage("Logging stream terminated unexpectedly"); client.terminationFuture().get(); } finally { // Verify that after termination, log levels are reset.